From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com ([143.182.124.37]) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UHwC3-0001EZ-4B for linux-mtd@lists.infradead.org; Tue, 19 Mar 2013 13:03:07 +0000 Message-ID: <1363698221.14966.17.camel@sauron.fi.intel.com> Subject: Re: [PATCH] mtd: bcm47xxsflash: implement chip polling From: Artem Bityutskiy To: =?UTF-8?Q?Rafa=C5=82_Mi=C5=82ecki?= Date: Tue, 19 Mar 2013 15:03:41 +0200 In-Reply-To: References: <1363343486-3084-1-git-send-email-zajec5@gmail.com> <51434BAC.4080003@hauke-m.de> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: Hauke Mehrtens , linux-mtd@lists.infradead.org, David Woodhouse Reply-To: dedekind1@gmail.com List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, 2013-03-15 at 17:43 +0100, Rafał Miłecki wrote: > To be honest, I had bus abstraction in my code. I removed it because > of Artem's comments in last patchset. He said he doesn't have a proof > I'll ever add SSB support and told me to remove code that prepared > bcm47xxsflash for abstracting bus type. I only asked to introduce it when you actually need it. I only objected to adding preparations without the code which uses the preparations. I do not really know the bcm47 HW, but of course if you have a HW resource which is shared between subsystems, you should not use it directly from MTD, you should have some kind of framework / accessors for the resource. -- Best Regards, Artem Bityutskiy