linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] UBIFS: fix missing unlock on error in ubifs_remount_rw()
@ 2013-03-18  3:12 Wei Yongjun
  2013-03-19 14:07 ` Artem Bityutskiy
  0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2013-03-18  3:12 UTC (permalink / raw)
  To: dedekind1, adrian.hunter; +Cc: yongjun_wei, linux-mtd, linux-kernel

From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

Add the missing unlock before return from function ubifs_remount_rw()
in the error handling case.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
 fs/ubifs/super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
index f21acf0..9791b3c 100644
--- a/fs/ubifs/super.c
+++ b/fs/ubifs/super.c
@@ -1571,7 +1571,7 @@ static int ubifs_remount_rw(struct ubifs_info *c)
 	if (c->space_fixup) {
 		err = ubifs_fixup_free_space(c);
 		if (err)
-			return err;
+			goto out;
 	}
 
 	err = check_free_space(c);

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] UBIFS: fix missing unlock on error in ubifs_remount_rw()
  2013-03-18  3:12 [PATCH -next] UBIFS: fix missing unlock on error in ubifs_remount_rw() Wei Yongjun
@ 2013-03-19 14:07 ` Artem Bityutskiy
  0 siblings, 0 replies; 2+ messages in thread
From: Artem Bityutskiy @ 2013-03-19 14:07 UTC (permalink / raw)
  To: Wei Yongjun; +Cc: yongjun_wei, linux-mtd, adrian.hunter, linux-kernel

On Mon, 2013-03-18 at 11:12 +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> 
> Add the missing unlock before return from function ubifs_remount_rw()
> in the error handling case.
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

Thanks, I fixed this up in linux-ubifs.git.

-- 
Best Regards,
Artem Bityutskiy

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-03-19 14:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-18  3:12 [PATCH -next] UBIFS: fix missing unlock on error in ubifs_remount_rw() Wei Yongjun
2013-03-19 14:07 ` Artem Bityutskiy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).