From: Namjae Jeon <linkinjeon@gmail.com>
To: dwmw2@infradead.org, axboe@kernel.dk, shli@kernel.org,
Paul.Clements@steeleye.com, npiggin@kernel.dk, neilb@suse.de,
cjb@laptop.org, adrian.hunter@intel.com
Cc: nbd-general@lists.sourceforge.net,
Namjae Jeon <linkinjeon@gmail.com>,
Vivek Trivedi <t.vivek@samsung.com>,
Namjae Jeon <namjae.jeon@samsung.com>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-raid@vger.kernel.org, linux-mtd@lists.infradead.org
Subject: [PATCH 3/8] mtd: use generic helper to set max_discard_sectors
Date: Sat, 13 Apr 2013 22:38:44 +0900 [thread overview]
Message-ID: <1365860324-21295-1-git-send-email-linkinjeon@gmail.com> (raw)
From: Namjae Jeon <namjae.jeon@samsung.com>
It is better to use blk_queue_max_discard_sectors helper
function to set max_discard_sectors as it checks
max_discard_sectors upper limit UINT_MAX >> 9
similar issue was reported for mmc in below link
https://lkml.org/lkml/2013/4/1/292
If multiple discard requests get merged, merged discard request's
size exceeds 4GB, there is possibility that merged discard request's
__data_len field may overflow.
This patch fixes this issue.
Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: Vivek Trivedi <t.vivek@samsung.com>
---
drivers/mtd/mtd_blkdevs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c
index 5ad39bb..cf35f99 100644
--- a/drivers/mtd/mtd_blkdevs.c
+++ b/drivers/mtd/mtd_blkdevs.c
@@ -417,7 +417,7 @@ int add_mtd_blktrans_dev(struct mtd_blktrans_dev *new)
if (tr->discard) {
queue_flag_set_unlocked(QUEUE_FLAG_DISCARD, new->rq);
- new->rq->limits.max_discard_sectors = UINT_MAX;
+ blk_queue_max_discard_sectors(new->rq, UINT_MAX >> 9);
}
gd->queue = new->rq;
--
1.7.9.5
next reply other threads:[~2013-04-13 13:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-13 13:38 Namjae Jeon [this message]
2013-05-13 7:08 ` [PATCH 3/8] mtd: use generic helper to set max_discard_sectors Artem Bityutskiy
2013-05-13 7:10 ` Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365860324-21295-1-git-send-email-linkinjeon@gmail.com \
--to=linkinjeon@gmail.com \
--cc=Paul.Clements@steeleye.com \
--cc=adrian.hunter@intel.com \
--cc=axboe@kernel.dk \
--cc=cjb@laptop.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-raid@vger.kernel.org \
--cc=namjae.jeon@samsung.com \
--cc=nbd-general@lists.sourceforge.net \
--cc=neilb@suse.de \
--cc=npiggin@kernel.dk \
--cc=shli@kernel.org \
--cc=t.vivek@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox