From: David Woodhouse <dwmw2@infradead.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
David Howells <dhowells@redhat.com>
Cc: Brad Spengler <spender@grsecurity.net>,
Suresh Siddha <suresh.b.siddha@intel.com>,
Artem Bityutskiy <dedekind1@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
linux-mtd@lists.infradead.org,
Ben Hutchings <ben@decadent.org.uk>
Subject: Re: [ 10/11] mtdchar: fix offset overflow detection
Date: Tue, 16 Apr 2013 09:41:31 +0100 [thread overview]
Message-ID: <1366101691.8222.4.camel@shinybook.infradead.org> (raw)
In-Reply-To: <20130415223532.GB10195@kroah.com>
[-- Attachment #1: Type: text/plain, Size: 1139 bytes --]
On Mon, 2013-04-15 at 15:35 -0700, Greg Kroah-Hartman wrote:
> On Mon, Apr 15, 2013 at 09:55:20PM +0100, David Woodhouse wrote:
> > On Sun, 2013-04-14 at 19:17 -0700, Greg Kroah-Hartman wrote:
> > > 3.0-stable review patch. If anyone has any objections, please let
> me know.
> >
> > Please use f5cf8f07423b2677cebebcebc863af77223a4972 instead (for 3.4
> > too).
>
> Really? I love the comment in that commit, "disable it for now until
> it
> can be fixed properly in the next merge window." Yet that was back in
> October of last year, no one has actually fixed this issue, is that
> because it can't be properly fixed, or just because no one got around
> to it?
Because nobody cared. It's only really used on uclinux for XIP mapping
of code from RAM anyway. Support for MMU systems was added as an
afterthought. and it shows.
ISTR I was blaming dhowells for it at the time, and hoping for him to
fix it. Although that remembrance may be incorrect, or I could even have
been incorrect at the time. I'm not going to investigate further right
now; I'm not here. 2 days into paternity leave...
--
dwmw2
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 6171 bytes --]
next prev parent reply other threads:[~2013-04-16 8:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20130415020614.067692418@linuxfoundation.org>
[not found] ` <20130415020614.846683113@linuxfoundation.org>
2013-04-15 20:55 ` [ 10/11] mtdchar: fix offset overflow detection David Woodhouse
2013-04-15 22:35 ` Greg Kroah-Hartman
2013-04-16 8:41 ` David Woodhouse [this message]
2013-04-22 1:22 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366101691.8222.4.camel@shinybook.infradead.org \
--to=dwmw2@infradead.org \
--cc=ben@decadent.org.uk \
--cc=dedekind1@gmail.com \
--cc=dhowells@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=spender@grsecurity.net \
--cc=stable@vger.kernel.org \
--cc=suresh.b.siddha@intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox