From: Artem Bityutskiy <dedekind1@gmail.com>
To: Huang Shijie <b32955@freescale.com>
Cc: linux-mtd@lists.infradead.org, computersforpeace@gmail.com,
dwmw2@infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V4 1/9] mtd: add more comment for ecc_strength/ecc_size
Date: Wed, 15 May 2013 10:27:50 +0300 [thread overview]
Message-ID: <1368602870.13665.7.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <1366967337-5534-2-git-send-email-b32955@freescale.com>
On Fri, 2013-04-26 at 17:08 +0800, Huang Shijie wrote:
> Add more commit for ecc_strength and ecc_size fields.
> We can treat the comment as the initial semantics for the two fields.
>
> Signed-off-by: Huang Shijie <b32955@freescale.com>
Huang, let me drop the 3 patches I already merged. Please, re-send them
in v5. I think this is better because I see you start applying patches
on top of them, which is a bit confusing.
> * @cellinfo: [INTERN] MLC/multichip data from chip ident
> * @ecc_strength: [INTERN] ECC correctability from the datasheet.
> + * The minimum number of bits correctability, if known;
> + * if unknown, set to 0.
I find this confusing still. How about this comment.
ECC correctability from the datasheet. Minumum amount of bit errors per
@ecc_size guaranteed to be correctable). If unknown, set to zero.
> * @ecc_size: [INTERN] ECC size required by the @ecc_strength,
> - * also from the datasheet.
> + * also from the datasheet. It is the recommended ECC step
> + * size, if known; if unknown, set to 0.
Silly question, why you call this one "ecc_size", and not "ecc_step"?
--
Best Regards,
Artem Bityutskiy
next prev parent reply other threads:[~2013-05-15 7:25 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-26 9:08 [PATCH V4 0/9] mtd: add datasheet's ECC information to nand_chip{} Huang Shijie
2013-04-26 9:08 ` [PATCH V4 1/9] mtd: add more comment for ecc_strength/ecc_size Huang Shijie
2013-05-15 7:27 ` Artem Bityutskiy [this message]
2013-05-15 7:38 ` Huang Shijie
2013-05-15 7:42 ` Artem Bityutskiy
2013-05-15 8:02 ` Huang Shijie
2013-05-15 10:01 ` Artem Bityutskiy
2013-04-26 9:08 ` [PATCH V4 2/9] mtd: add data structures for Extended Parameter Page Huang Shijie
2013-05-02 7:42 ` Gupta, Pekon
2013-04-26 9:08 ` [PATCH V4 3/9] mtd: add a helper to get the supported features for ONFI nand Huang Shijie
2013-04-26 9:08 ` [PATCH V4 4/9] mtd: get the ECC info from the Extended Parameter Page Huang Shijie
2013-05-02 7:43 ` Gupta, Pekon
2013-05-02 23:39 ` Brian Norris
2013-05-03 2:52 ` Huang Shijie
2013-04-26 9:08 ` [PATCH V4 5/9] mtd: replace the hardcode with the onfi_feature() Huang Shijie
2013-04-30 10:04 ` Gupta, Pekon
2013-05-02 2:14 ` Huang Shijie
2013-05-02 5:42 ` Gupta, Pekon
2013-05-02 6:01 ` Huang Shijie
2013-05-02 6:17 ` Gupta, Pekon
2013-05-02 6:48 ` Huang Shijie
2013-05-02 21:24 ` Brian Norris
2013-04-26 9:08 ` [PATCH V4 6/9] mtd: add ECC info for nand_flash_dev{} Huang Shijie
2013-04-26 9:08 ` [PATCH V4 7/9] mtd: parse out the ECC info for the full-id nand chips Huang Shijie
2013-04-26 9:08 ` [PATCH V4 8/9] mtd: add the ecc info for some " Huang Shijie
2013-04-26 9:08 ` [PATCH V4 9/9] mtd: gpmi: set the BCH's geometry with the ecc info Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368602870.13665.7.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=b32955@freescale.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox