From: "Gupta, Pekon" <pekon@ti.com>
To: <linux-mtd@lists.infradead.org>, <linux-omap@vger.kernel.org>
Cc: arnd@arndb.de, tony@atomide.com, jp.francois@cynove.com,
balbi@ti.com, "Gupta, Pekon" <pekon@ti.com>
Subject: [PATCH 4/4 v2] ARM: OMAP2+: updated ECC scheme attributes for omap2-nand DT
Date: Fri, 17 May 2013 17:20:18 +0530 [thread overview]
Message-ID: <1368791418-14330-5-git-send-email-pekon@ti.com> (raw)
In-Reply-To: <1368791418-14330-1-git-send-email-pekon@ti.com>
From: "Gupta, Pekon" <pekon@ti.com>
Updates ECC scheme selection string same to same as used in omap2-driver code.
This makes the DT configurations easy to understand and map to actual code.
Signed-off-by: Gupta, Pekon <pekon@ti.com>
---
.../devicetree/bindings/mtd/gpmc-nand.txt | 47 ++++++++++++++--------
arch/arm/boot/dts/am335x-evm.dts | 2 +-
arch/arm/mach-omap2/gpmc.c | 19 +++++----
3 files changed, 43 insertions(+), 25 deletions(-)
diff --git a/Documentation/devicetree/bindings/mtd/gpmc-nand.txt b/Documentation/devicetree/bindings/mtd/gpmc-nand.txt
index de180be..c7a4add 100644
--- a/Documentation/devicetree/bindings/mtd/gpmc-nand.txt
+++ b/Documentation/devicetree/bindings/mtd/gpmc-nand.txt
@@ -25,22 +25,37 @@ Optional properties:
- ti,nand-ecc-opt: Determines the ECC scheme used by driver.
It can be any of the following strings:
- "hamming_sw" 1-bit Hamming ECC using software
-
- "hamming_hw" 1-bit Hamming ECC using hardware
-
- "hamming_hw_romcode" 1-bit Hamming ECC using hardware
- - ECC layout compatible to ROM code
-
- "bch8_hw_detection_sw" 8-bit BCH with ECC calculation in hardware
- and error detection in software
- - requires Kconfig CONFIG_MTD_NAND_ECC_BCH
-
- "bch8_hw" 8-bit BCH with ECC calculation in hardware
- and error detection in hardware
- - requires <elm_id> to be specified
- - requires Kconfig CONFIG_MTD_NAND_OMAP_BCH
-
+ "OMAP_ECC_HAMMING_CODE_SW"
+ 1-bit Hamming ECC using software.
+
+ "OMAP_ECC_HAMMING_CODE_HW"
+ 1-bit Hamming ECC using hardware.
+
+ "OMAP_ECC_HAMMING_CODE_HW_ROMCODE"
+ 1-bit Hamming ECC using hardware with
+ ECC layout compatible to ROM code.
+
+ "OMAP_ECC_BCH4_CODE_HW_DETECTION_SW"
+ 4-bit BCH with ECC calculation in
+ hardware & error detection in software.
+ - requires CONFIG_MTD_NAND_ECC_BCH
+
+ "OMAP_ECC_BCH4_CODE_HW"
+ 4-bit BCH with ECC calculation in
+ hardware & error detection in hardware.
+ - requires CONFIG_MTD_NAND_OMAP_BCH
+ - requires <elm_id> to be specified
+
+ "OMAP_ECC_BCH8_CODE_HW_DETECTION_SW"
+ 8-bit BCH with ECC calculation in
+ hardware & error detection in software.
+ - requires CONFIG_MTD_NAND_ECC_BCH
+
+ "OMAP_ECC_BCH8_CODE_HW"
+ 8-bit BCH with ECC calculation in
+ hardware & error detection in hardware.
+ - requires CONFIG_MTD_NAND_OMAP_BCH
+ - requires <elm_id> to be specified
- elm_id: Specifies elm device node. This is required to
diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts
index 60e8f59..1107761 100644
--- a/arch/arm/boot/dts/am335x-evm.dts
+++ b/arch/arm/boot/dts/am335x-evm.dts
@@ -135,7 +135,7 @@
nand@0,0 {
reg = <0 0 0>; /* CS0, offset 0 */
nand-bus-width = <8>;
- ti,nand-ecc-opt = "bch8_hw";
+ ti,nand-ecc-opt = "OMAP_ECC_BCH8_CODE_HW";
gpmc,sync-clk = <0>;
gpmc,cs-on = <0>;
diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c
index 03b8027..e3146c3 100644
--- a/arch/arm/mach-omap2/gpmc.c
+++ b/arch/arm/mach-omap2/gpmc.c
@@ -1205,13 +1205,16 @@ static void __maybe_unused gpmc_read_timings_dt(struct device_node *np,
#ifdef CONFIG_MTD_NAND
static const char * const nand_ecc_opts[] = {
- [OMAP_ECC_HAMMING_CODE_DEFAULT] = "hamming_sw",
- [OMAP_ECC_HAMMING_CODE_HW] = "hamming_hw",
- [OMAP_ECC_HAMMING_CODE_HW_ROMCODE] = "hamming_hw_romcode",
- [OMAP_ECC_BCH4_CODE_HW] = "bch4_hw",
- [OMAP_ECC_BCH4_CODE_HW_DETECTION_SW] = "bch4_hw_detection_sw",
- [OMAP_ECC_BCH8_CODE_HW] = "bch8_hw",
- [OMAP_ECC_BCH8_CODE_HW_DETECTION_SW] = "bch8_hw_detection_sw"
+ [OMAP_ECC_HAMMING_CODE_DEFAULT] = "OMAP_ECC_HAMMING_CODE_SW",
+ [OMAP_ECC_HAMMING_CODE_HW] = "OMAP_ECC_HAMMING_CODE_HW",
+ [OMAP_ECC_HAMMING_CODE_HW_ROMCODE] =
+ "OMAP_ECC_HAMMING_CODE_HW_ROMCODE",
+ [OMAP_ECC_BCH4_CODE_HW_DETECTION_SW] =
+ "OMAP_ECC_BCH4_CODE_HW_DETECTION_SW",
+ [OMAP_ECC_BCH4_CODE_HW] = "OMAP_ECC_BCH4_CODE_HW",
+ [OMAP_ECC_BCH8_CODE_HW_DETECTION_SW] =
+ "OMAP_ECC_BCH8_CODE_HW_DETECTION_SW",
+ [OMAP_ECC_BCH8_CODE_HW] = "OMAP_ECC_BCH8_CODE_HW"
};
static int gpmc_probe_nand_child(struct platform_device *pdev,
@@ -1238,7 +1241,7 @@ static int gpmc_probe_nand_child(struct platform_device *pdev,
if (!of_property_read_string(child, "ti,nand-ecc-opt", &s))
for (val = 0; val < ARRAY_SIZE(nand_ecc_opts); val++)
- if (!strcasecmp(s, nand_ecc_opts[val])) {
+ if (!strcmp(s, nand_ecc_opts[val])) {
gpmc_nand_data->ecc_opt = val;
break;
}
--
1.8.1
next prev parent reply other threads:[~2013-05-17 11:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-17 11:50 [PATCH 0/4 v2] mtd:nand:omap2: clean-up of supported ECC schemes Gupta, Pekon
2013-05-17 11:50 ` [PATCH 1/4 v2] mtd:nand:omap2: clean-up BCHx_HW and BCHx_SW ECC configurations in device_probe Gupta, Pekon
2013-05-17 11:50 ` [PATCH 2/4 v2] ARM: OMAP2+: cleaned-up DT support of various ECC schemes Gupta, Pekon
2013-05-17 11:50 ` [PATCH 3/4 v2] mtd:nand:omap2: updated support for BCH4 ECC scheme Gupta, Pekon
2013-05-17 11:50 ` Gupta, Pekon [this message]
2013-05-17 12:46 ` [PATCH 4/4 v2] ARM: OMAP2+: updated ECC scheme attributes for omap2-nand DT Arnd Bergmann
2013-05-18 11:05 ` Gupta, Pekon
2013-05-24 13:01 ` [PATCH 0/4 v2] mtd:nand:omap2: clean-up of supported ECC schemes jean-philippe francois
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368791418-14330-5-git-send-email-pekon@ti.com \
--to=pekon@ti.com \
--cc=arnd@arndb.de \
--cc=balbi@ti.com \
--cc=jp.francois@cynove.com \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox