* [PATCH 05/13] mtd: gpmi-nand : Let device core handle pinctrl
[not found] <1367863561-11534-1-git-send-email-fabio.estevam@freescale.com>
@ 2013-05-06 18:05 ` Fabio Estevam
2013-05-26 21:00 ` Fabio Estevam
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Fabio Estevam @ 2013-05-06 18:05 UTC (permalink / raw)
To: shawn.guo; +Cc: Fabio Estevam, Artem Bityutskiy, linux-mtd, festevam, kernel
Since commit ab78029 (drivers/pinctrl: grab default handles from device core),
we can rely on device core for handling pinctrl.
So remove devm_pinctrl_get_select_default() from the driver.
Cc: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Cc: <linux-mtd@lists.infradead.org>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
index 717881a..e8adefa 100644
--- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
+++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
@@ -26,7 +26,6 @@
#include <linux/interrupt.h>
#include <linux/module.h>
#include <linux/mtd/partitions.h>
-#include <linux/pinctrl/consumer.h>
#include <linux/of.h>
#include <linux/of_device.h>
#include <linux/of_mtd.h>
@@ -565,7 +564,6 @@ err_clock:
static int acquire_resources(struct gpmi_nand_data *this)
{
- struct pinctrl *pinctrl;
int ret;
ret = acquire_register_block(this, GPMI_NAND_GPMI_REGS_ADDR_RES_NAME);
@@ -584,19 +582,12 @@ static int acquire_resources(struct gpmi_nand_data *this)
if (ret)
goto exit_dma_channels;
- pinctrl = devm_pinctrl_get_select_default(&this->pdev->dev);
- if (IS_ERR(pinctrl)) {
- ret = PTR_ERR(pinctrl);
- goto exit_pin;
- }
-
ret = gpmi_get_clks(this);
if (ret)
goto exit_clock;
return 0;
exit_clock:
-exit_pin:
release_dma_channels(this);
exit_dma_channels:
release_bch_irq(this);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 05/13] mtd: gpmi-nand : Let device core handle pinctrl
2013-05-06 18:05 ` [PATCH 05/13] mtd: gpmi-nand : Let device core handle pinctrl Fabio Estevam
@ 2013-05-26 21:00 ` Fabio Estevam
2013-07-01 5:19 ` Artem Bityutskiy
2013-07-01 11:49 ` Artem Bityutskiy
2 siblings, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2013-05-26 21:00 UTC (permalink / raw)
To: Artem Bityutskiy, Fabio Estevam; +Cc: shawn.guo, linux-mtd, kernel
Hi Artem,
On Mon, May 6, 2013 at 3:05 PM, Fabio Estevam
<fabio.estevam@freescale.com> wrote:
> Since commit ab78029 (drivers/pinctrl: grab default handles from device core),
> we can rely on device core for handling pinctrl.
>
> So remove devm_pinctrl_get_select_default() from the driver.
>
> Cc: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> Cc: <linux-mtd@lists.infradead.org>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Any comments on this one?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 05/13] mtd: gpmi-nand : Let device core handle pinctrl
2013-05-06 18:05 ` [PATCH 05/13] mtd: gpmi-nand : Let device core handle pinctrl Fabio Estevam
2013-05-26 21:00 ` Fabio Estevam
@ 2013-07-01 5:19 ` Artem Bityutskiy
2013-07-01 11:27 ` Fabio Estevam
2013-07-01 11:49 ` Artem Bityutskiy
2 siblings, 1 reply; 5+ messages in thread
From: Artem Bityutskiy @ 2013-07-01 5:19 UTC (permalink / raw)
To: Fabio Estevam; +Cc: festevam, shawn.guo, linux-mtd, kernel
On Mon, 2013-05-06 at 15:05 -0300, Fabio Estevam wrote:
> Since commit ab78029 (drivers/pinctrl: grab default handles from device core),
> we can rely on device core for handling pinctrl.
>
> So remove devm_pinctrl_get_select_default() from the driver.
>
> Cc: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> Cc: <linux-mtd@lists.infradead.org>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
--
Best Regards,
Artem Bityutskiy
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 05/13] mtd: gpmi-nand : Let device core handle pinctrl
2013-07-01 5:19 ` Artem Bityutskiy
@ 2013-07-01 11:27 ` Fabio Estevam
0 siblings, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2013-07-01 11:27 UTC (permalink / raw)
To: artem.bityutskiy; +Cc: Fabio Estevam, shawn.guo, linux-mtd, kernel
On Mon, Jul 1, 2013 at 2:19 AM, Artem Bityutskiy
<artem.bityutskiy@linux.intel.com> wrote:
> On Mon, 2013-05-06 at 15:05 -0300, Fabio Estevam wrote:
>> Since commit ab78029 (drivers/pinctrl: grab default handles from device core),
>> we can rely on device core for handling pinctrl.
>>
>> So remove devm_pinctrl_get_select_default() from the driver.
>>
>> Cc: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
>> Cc: <linux-mtd@lists.infradead.org>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>
> Acked-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Thanks, Artem.
Could you please apply this into your tree?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 05/13] mtd: gpmi-nand : Let device core handle pinctrl
2013-05-06 18:05 ` [PATCH 05/13] mtd: gpmi-nand : Let device core handle pinctrl Fabio Estevam
2013-05-26 21:00 ` Fabio Estevam
2013-07-01 5:19 ` Artem Bityutskiy
@ 2013-07-01 11:49 ` Artem Bityutskiy
2 siblings, 0 replies; 5+ messages in thread
From: Artem Bityutskiy @ 2013-07-01 11:49 UTC (permalink / raw)
To: Fabio Estevam; +Cc: festevam, shawn.guo, linux-mtd, kernel
On Mon, 2013-05-06 at 15:05 -0300, Fabio Estevam wrote:
> Since commit ab78029 (drivers/pinctrl: grab default handles from device core),
> we can rely on device core for handling pinctrl.
>
> So remove devm_pinctrl_get_select_default() from the driver.
Pushed to l2-mtd.git, thanks!
--
Best Regards,
Artem Bityutskiy
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-07-01 11:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1367863561-11534-1-git-send-email-fabio.estevam@freescale.com>
2013-05-06 18:05 ` [PATCH 05/13] mtd: gpmi-nand : Let device core handle pinctrl Fabio Estevam
2013-05-26 21:00 ` Fabio Estevam
2013-07-01 5:19 ` Artem Bityutskiy
2013-07-01 11:27 ` Fabio Estevam
2013-07-01 11:49 ` Artem Bityutskiy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox