* [PATCH] nand: mxc_nand: Remove unneeded check for platform_get_resource()
@ 2013-07-21 17:52 Fabio Estevam
2013-08-02 15:34 ` Artem Bityutskiy
0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2013-07-21 17:52 UTC (permalink / raw)
To: dwmw2; +Cc: Fabio Estevam, artem.bityutskiy, s.hauer, linux-mtd
From: Fabio Estevam <fabio.estevam@freescale.com>
devm_ioremap_resource() checks its arguments, so there is no need for
explicitly checking the return value from platform_get_resource().
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/mtd/nand/mxc_nand.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/mtd/nand/mxc_nand.c b/drivers/mtd/nand/mxc_nand.c
index 18855ad..0581bd3 100644
--- a/drivers/mtd/nand/mxc_nand.c
+++ b/drivers/mtd/nand/mxc_nand.c
@@ -1446,8 +1446,6 @@ static int mxcnd_probe(struct platform_device *pdev)
if (host->devtype_data->needs_ip) {
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!res)
- return -ENODEV;
host->regs_ip = devm_ioremap_resource(&pdev->dev, res);
if (IS_ERR(host->regs_ip))
return PTR_ERR(host->regs_ip);
@@ -1457,9 +1455,6 @@ static int mxcnd_probe(struct platform_device *pdev)
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
}
- if (!res)
- return -ENODEV;
-
host->base = devm_ioremap_resource(&pdev->dev, res);
if (IS_ERR(host->base))
return PTR_ERR(host->base);
--
1.8.1.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] nand: mxc_nand: Remove unneeded check for platform_get_resource()
2013-07-21 17:52 [PATCH] nand: mxc_nand: Remove unneeded check for platform_get_resource() Fabio Estevam
@ 2013-08-02 15:34 ` Artem Bityutskiy
0 siblings, 0 replies; 2+ messages in thread
From: Artem Bityutskiy @ 2013-08-02 15:34 UTC (permalink / raw)
To: Fabio Estevam; +Cc: Fabio Estevam, linux-mtd, s.hauer, dwmw2
On Sun, 2013-07-21 at 14:52 -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> devm_ioremap_resource() checks its arguments, so there is no need for
> explicitly checking the return value from platform_get_resource().
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Pushed to l2-mtd.git, thanks!
--
Best Regards,
Artem Bityutskiy
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-02 15:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-21 17:52 [PATCH] nand: mxc_nand: Remove unneeded check for platform_get_resource() Fabio Estevam
2013-08-02 15:34 ` Artem Bityutskiy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox