From: Artem Bityutskiy <dedekind1@gmail.com>
To: Akinobu Mita <akinobu.mita@gmail.com>
Cc: linux-mtd@lists.infradead.org,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH 1/6] mtd: nandsim: convert pages_written[] to bitmap
Date: Fri, 02 Aug 2013 18:46:04 +0300 [thread overview]
Message-ID: <1375458364.14869.348.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <1375454326.14869.325.camel@sauron.fi.intel.com>
On Fri, 2013-08-02 at 17:38 +0300, Artem Bityutskiy wrote:
> On Sun, 2013-07-28 at 11:21 +0900, Akinobu Mita wrote:
> > nandsim.pages_written[] is the array of unsigned char which is indexed
> > by the page number and used for identifying which pages have been written
> > when cache_file is used. Each entry holds 0 (not written) or 1 (written),
> > so it can be converted to bitmap. This reduces the allocation size of
> > pages_written[] by 1/8.
>
> Did you test this patch-set, if yes, how?
Note, I am asking because this is an ancient and probably poor piece of
code, but quite important, so I am just trying to understand whether I
should test your patches before applying, and if yes, how.
--
Best Regards,
Artem Bityutskiy
next prev parent reply other threads:[~2013-08-02 15:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-28 2:21 [PATCH 1/6] mtd: nandsim: convert pages_written[] to bitmap Akinobu Mita
2013-07-28 2:21 ` [PATCH 2/6] mtd: nandsim: use kasprintf() Akinobu Mita
2013-07-28 2:21 ` [PATCH 3/6] mtd: nandsim: simplify NS_RAW_OFFSET() Akinobu Mita
2013-07-28 2:21 ` [PATCH 4/6] mtd: nandsim: use NS_RAW_OFFSET() Akinobu Mita
2013-07-28 2:21 ` [PATCH 5/6] mtd: nandsim: remove unused code Akinobu Mita
2013-07-28 2:21 ` [PATCH 6/6] mtd: nandsim: remove unused ns->geom.oobshift Akinobu Mita
2013-08-02 14:38 ` [PATCH 1/6] mtd: nandsim: convert pages_written[] to bitmap Artem Bityutskiy
2013-08-02 15:46 ` Artem Bityutskiy [this message]
2013-08-02 15:59 ` Akinobu Mita
2013-08-05 13:02 ` Artem Bityutskiy
2013-08-05 23:02 ` Akinobu Mita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375458364.14869.348.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=akinobu.mita@gmail.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox