warning or debug text ?

warning or debug text ?

[Kenneth Johansson]

in cfi_cmdset_0002.c I hit this line a lot when I created the feedback loop
with the log file on a jffs2 partition.. I don't see is so often now but
still is it needed??

   printk("Waiting for chip to read, status = %d\n", chip->state);

It's a few printk in this file that has nothing indication the type of the
message and no text informing the user on what subsystem it's comming from.

In the mtd subsystem it's ALOT of this. Should I just add KERN_DEBUG to
everything ?? It's not nice to get stuff on the console when it's only a
warning or debug info.


-- 
Kenneth Johansson	
Ericsson Business Innovation AB   Tel: +46 8 404 71 83
Viderögatan 3                     Fax: +46 8 404 72 72
164 80 Stockholm                  kenneth.johansson@inn.ericsson.se

Re: warning or debug text ?

[David Woodhouse]

kenneth.johansson@inn.ericsson.se said:
>  In the mtd subsystem it's ALOT of this. Should I just add KERN_DEBUG
> to everything ?? It's not nice to get stuff on the console when it's
> only a warning or debug info. 

Making them KERN_DEBUG or better still putting them inside some kind of 
DEBUG macro like the ones in some other files would be useful. If you do 
this, please could you let me have a patch?

--
dwmw2