Re: [PATCH 04/25] mtd: nand: gpmi-nand: janitorial cleanup: (commas after last element of struct initializer)

[Artem Bityutskiy <artem.bityutskiy@linux.intel.com>]

On Thu, 2013-08-01 at 07:50 +0200, Lothar Waßmann wrote:
> Hi,
> 
> Huang Shijie writes:
> > 于 2013年07月31日 22:11, Lothar Waßmann 写道:
> > > Signed-off-by: Lothar Waßmann<LW@KARO-electronics.de>
> > > ---
> > >   drivers/mtd/nand/gpmi-nand/gpmi-nand.c |    8 ++++----
> > >   1 files changed, 4 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> > > index f557a1d..4f7ec59 100644
> > > --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> > > +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> > > @@ -1569,19 +1569,19 @@ static const struct platform_device_id gpmi_ids[] = {
> > >   	{ .name = "imx23-gpmi-nand", .driver_data = IS_MX23, },
> > >   	{ .name = "imx28-gpmi-nand", .driver_data = IS_MX28, },
> > >   	{ .name = "imx6q-gpmi-nand", .driver_data = IS_MX6Q, },
> > > -	{},
> > > +	{}
> > >   };
> > >
> > >   static const struct of_device_id gpmi_nand_id_table[] = {
> > >   	{
> > >   		.compatible = "fsl,imx23-gpmi-nand",
> > > -		.data = (void *)&gpmi_ids[IS_MX23]
> > > +		.data = (void *)&gpmi_ids[IS_MX23],
> > >   	}, {
> > >   		.compatible = "fsl,imx28-gpmi-nand",
> > > -		.data = (void *)&gpmi_ids[IS_MX28]
> > > +		.data = (void *)&gpmi_ids[IS_MX28],
> > >   	}, {
> > >   		.compatible = "fsl,imx6q-gpmi-nand",
> > > -		.data = (void *)&gpmi_ids[IS_MX6Q]
> > > +		.data = (void *)&gpmi_ids[IS_MX6Q],
> > >   	}, {}
> > >   };
> > >   MODULE_DEVICE_TABLE(of, gpmi_nand_id_table);
> > is it any bad influence if we do not apply this patch?
> > 
> > I am not clear what we can benefit from this patch.
> > 
> less eye sore when looking at the code and eventual copies of it in
> other places.

For some reasons I do not have these patches in my mailbox. Would you
please re-send them, and add the acks there too?

-- 
Best Regards,
Artem Bityutskiy