public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Huang Shijie <b32955@freescale.com>
Cc: linux-mtd@lists.infradead.org, computersforpeace@gmail.com,
	dwmw2@infradead.org, pekon@ti.com
Subject: Re: [PATCH v4 6/6] mtd: update the ABI document about the ecc step size
Date: Fri, 16 Aug 2013 16:45:59 +0300	[thread overview]
Message-ID: <1376660759.2089.358.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <1376619009-8622-7-git-send-email-b32955@freescale.com>

On Fri, 2013-08-16 at 10:10 +0800, Huang Shijie wrote:
> +
> +What:          /sys/class/mtd/mtdX/ecc_step_size
> +Date:          May 2013
> +KernelVersion: 3.10
> +Contact:       linux-mtd@lists.infradead.org
> +Description:
> +               The size of each ECC step which is used for ECC.
> +               Note that some devices will have multiple ecc steps within each
> +               writesize region.

Actually this phrase is a bit confusing because it may be interpreted as
that one write-size may have ECC steps of multiple sizes. Would you
re-phrase, may be?

Otherwise the patch-set looks good, thanks, but I am not merging the
patches to let Brian review.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>

-- 
Best Regards,
Artem Bityutskiy

  reply	other threads:[~2013-08-16 13:40 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-16  2:10 [PATCH v4 0/6] Export the ECC step size to user applications Huang Shijie
2013-08-16  2:10 ` [PATCH v4 1/6] mtd: add a new field to mtd_info{} Huang Shijie
2013-08-16  2:10 ` [PATCH v4 2/6] mtd: add a new sys node to show the ecc step size Huang Shijie
2013-08-16  2:10 ` [PATCH v4 3/6] mtd: set the ecc step size for master/slave mtd_info Huang Shijie
2013-08-16  2:10 ` [PATCH v4 4/6] mtd: set ONFI nand's default hooks in nand_set_defaults() Huang Shijie
2013-08-17 17:55   ` Brian Norris
2013-08-19  8:06     ` Brian Foster
2013-08-20  0:41       ` Brian Norris
2013-08-20  7:09         ` Brian Foster
2013-08-16  2:10 ` [PATCH v4 5/6] mtd: gpmi: remove the nand_scan() Huang Shijie
2013-08-16  2:10 ` [PATCH v4 6/6] mtd: update the ABI document about the ecc step size Huang Shijie
2013-08-16 13:45   ` Artem Bityutskiy [this message]
2013-08-17  3:26     ` Huang Shijie
2013-08-17 18:14       ` Brian Norris
2013-08-18 14:29         ` Huang Shijie
2013-08-20  1:02           ` Brian Norris
2013-08-20  2:11             ` Huang Shijie
2013-08-17 18:35 ` [PATCH v4 0/6] Export the ECC step size to user applications Brian Norris
2013-08-18 14:48   ` Huang Shijie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1376660759.2089.358.camel@sauron.fi.intel.com \
    --to=dedekind1@gmail.com \
    --cc=b32955@freescale.com \
    --cc=computersforpeace@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=pekon@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox