From: David Woodhouse <dwmw2@infradead.org>
To: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Lior Amsalem <alior@marvell.com>,
Jason Cooper <jason@lakedaemon.net>,
Artem Bityutskiy <dedekind1@gmail.com>,
Daniel Mack <zonque@gmail.com>,
devicetree@vger.kernel.org, linux-mtd@lists.infradead.org,
Gregory Clement <gregory.clement@free-electrons.com>,
Brian Norris <computersforpeace@gmail.com>,
Willy Tarreau <w@1wt.eu>
Subject: Re: [PATCH v4 01/14] mtd: nand: pxa3xx: Remove unneeded ifdef CONFIG_OF
Date: Fri, 30 Aug 2013 21:06:22 +0100 [thread overview]
Message-ID: <1377893182.22372.83.camel@shinybook.infradead.org> (raw)
In-Reply-To: <1376327699-7973-2-git-send-email-ezequiel.garcia@free-electrons.com>
[-- Attachment #1: Type: text/plain, Size: 362 bytes --]
On Mon, 2013-08-12 at 14:14 -0300, Ezequiel Garcia wrote:
> There's no need to enclose this code within idef CONFIG_OF,
> because the OF framework provides no-op stubs if CONFIG_OF=n.
Hm, won't this end up with the same 'pxa3xx_nand_dt_ids is defined but
not used' warning that just caused us to *add* an #ifdef CONFIG_OF to
atmel_nand?
--
dwmw2
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5745 bytes --]
next prev parent reply other threads:[~2013-08-30 20:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-12 17:14 [PATCH v4 00/14] pxa3xx-nand patches to support mvebu builds Ezequiel Garcia
2013-08-12 17:14 ` [PATCH v4 01/14] mtd: nand: pxa3xx: Remove unneeded ifdef CONFIG_OF Ezequiel Garcia
2013-08-30 20:06 ` David Woodhouse [this message]
2013-08-31 16:53 ` Ezequiel Garcia
2013-09-16 22:57 ` Olof Johansson
2013-08-12 17:14 ` [PATCH v4 02/14] mtd: nand: pxa3xx: Introduce 'marvell, armada370-nand' compatible string Ezequiel Garcia
2013-08-12 17:14 ` [PATCH v4 03/14] mtd: nand: pxa3xx: Handle ECC and DMA enable/disable properly Ezequiel Garcia
2013-08-12 17:14 ` [PATCH v4 04/14] mtd: nand: pxa3xx: Allow to set/clear the 'spare enable' field Ezequiel Garcia
2013-08-12 17:14 ` [PATCH v4 05/14] mtd: nand: pxa3xx: Support command buffer #3 Ezequiel Garcia
2013-08-12 17:14 ` [PATCH v4 06/14] mtd: nand: pxa3xx: Use 'length override' in ONFI paramater page read Ezequiel Garcia
2013-08-12 17:14 ` [PATCH v4 07/14] mtd: nand: pxa3xx: Add a local loop variable Ezequiel Garcia
2013-08-12 17:14 ` [PATCH v4 08/14] mtd: nand: pxa3xx: Remove hardcoded mtd name Ezequiel Garcia
2013-08-12 23:18 ` Brian Norris
2013-08-12 17:14 ` [PATCH v4 09/14] mtd: nand: pxa3xx: Remove uneeded internal cmdset Ezequiel Garcia
2013-08-12 17:14 ` [PATCH v4 10/14] mtd: nand: pxa3xx: Move cached registers to info structure Ezequiel Garcia
2013-08-12 17:14 ` [PATCH v4 11/14] mtd: nand: pxa3xx: Make dma code dependent on dma capable platforms Ezequiel Garcia
2013-08-12 17:14 ` [PATCH v4 12/14] mtd: nand: pxa3xx: Add __maybe_unused keyword to enable_int() Ezequiel Garcia
2013-08-12 17:14 ` [PATCH v4 13/14] mtd: nand: pxa3xx: Allow devices with no dma resources Ezequiel Garcia
2013-08-12 17:14 ` [PATCH v4 14/14] mtd: nand: Allow to build pxa3xx_nand on Orion platforms Ezequiel Garcia
2013-08-12 23:19 ` [PATCH v4 00/14] pxa3xx-nand patches to support mvebu builds Brian Norris
2013-08-13 11:37 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377893182.22372.83.camel@shinybook.infradead.org \
--to=dwmw2@infradead.org \
--cc=alior@marvell.com \
--cc=computersforpeace@gmail.com \
--cc=dedekind1@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=ezequiel.garcia@free-electrons.com \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=linux-mtd@lists.infradead.org \
--cc=thomas.petazzoni@free-electrons.com \
--cc=w@1wt.eu \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox