From: Brian Norris <computersforpeace@gmail.com>
To: <linux-mtd@lists.infradead.org>
Cc: Marek Vasut <marex@denx.de>,
devicetree@vger.kernel.org,
Artem Bityutskiy <dedekind1@gmail.com>,
Rob Herring <rob.herring@calxeda.com>,
Grant Likely <grant.likely@linaro.org>,
sourav.poddar@ti.com, Brian Norris <computersforpeace@gmail.com>
Subject: [PATCH 5/5] mtd: m25p80: remove 'disabled' device check
Date: Wed, 23 Oct 2013 19:58:23 -0700 [thread overview]
Message-ID: <1382583503-13748-5-git-send-email-computersforpeace@gmail.com> (raw)
In-Reply-To: <1382583503-13748-1-git-send-email-computersforpeace@gmail.com>
It seems like the following commit was never necessary
commit 5f949137952020214cd167093dd7be448f21c079
Author: Shaohui Xie <Shaohui.Xie@freescale.com>
Date: Fri Oct 14 15:49:00 2011 +0800
mtd: m25p80: don't probe device which has status of 'disabled'
because it duplicates the code in of_platform_device_create_pdata()
which ensures that 'disabled' nodes are never instantiated.
Also, drop the __maybe_unused.
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Cc: Grant Likely <grant.likely@linaro.org>
Cc: Rob Herring <rob.herring@calxeda.com>
Cc: <devicetree@vger.kernel.org>
---
drivers/mtd/devices/m25p80.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
index d6c5c57..a1dc49a 100644
--- a/drivers/mtd/devices/m25p80.c
+++ b/drivers/mtd/devices/m25p80.c
@@ -935,12 +935,7 @@ static int m25p_probe(struct spi_device *spi)
struct flash_info *info;
unsigned i;
struct mtd_part_parser_data ppdata;
- struct device_node __maybe_unused *np = spi->dev.of_node;
-
-#ifdef CONFIG_MTD_OF_PARTS
- if (!of_device_is_available(np))
- return -ENODEV;
-#endif
+ struct device_node *np = spi->dev.of_node;
/* Platform data helps sort out which chip type we have, as
* well as how this board partitions it. If we don't have
--
1.8.4
next prev parent reply other threads:[~2013-10-24 3:00 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 2:58 [PATCH 1/5] mtd: m25p80: fix allocation size Brian Norris
2013-10-24 2:58 ` [PATCH 2/5] mtd: m25p80: remove obsolete FIXME Brian Norris
2013-10-24 9:01 ` Sourav Poddar
2013-10-27 16:30 ` Marek Vasut
2013-10-24 2:58 ` [PATCH 3/5] mtd: m25p80: re-align ID entries Brian Norris
2013-10-24 9:01 ` Sourav Poddar
2013-10-24 2:58 ` [PATCH 4/5] mtd: m25p80: remove M25PXX_USE_FAST_READ Kconfig Brian Norris
2013-10-24 9:07 ` Sourav Poddar
2013-10-24 9:12 ` Sourav Poddar
2013-10-24 17:39 ` Brian Norris
2013-10-24 18:48 ` Sourav Poddar
2013-10-25 17:59 ` Brian Norris
2013-10-27 16:32 ` Marek Vasut
2013-10-30 23:38 ` Brian Norris
2013-10-31 9:21 ` Marek Vasut
2013-10-31 9:50 ` Sourav Poddar
2013-10-31 14:55 ` Brian Norris
2013-11-01 12:26 ` Marek Vasut
2013-11-05 3:37 ` Brian Norris
2013-11-05 13:14 ` Marek Vasut
2013-10-24 2:58 ` Brian Norris [this message]
2013-10-24 9:01 ` [PATCH 5/5] mtd: m25p80: remove 'disabled' device check Sourav Poddar
2013-10-25 0:15 ` Grant Likely
2013-10-25 18:01 ` Brian Norris
2013-10-24 9:00 ` [PATCH 1/5] mtd: m25p80: fix allocation size Sourav Poddar
2013-10-24 17:17 ` Brian Norris
2013-10-24 17:56 ` Sourav Poddar
2013-10-27 16:30 ` Marek Vasut
2013-10-27 22:48 ` Brian Norris
2013-10-28 7:54 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1382583503-13748-5-git-send-email-computersforpeace@gmail.com \
--to=computersforpeace@gmail.com \
--cc=dedekind1@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marex@denx.de \
--cc=rob.herring@calxeda.com \
--cc=sourav.poddar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).