* [PATCH] mtd-utils: Makefile: add LDFLAGS_mkfs.ubifs
[not found] <0e757815-7fea-4f97-858a-9f110851b86f@zimbra>
@ 2013-09-27 16:34 ` Aaron Sierra
2013-10-26 10:26 ` Artem Bityutskiy
0 siblings, 1 reply; 2+ messages in thread
From: Aaron Sierra @ 2013-09-27 16:34 UTC (permalink / raw)
To: Artem Bityutskiy; +Cc: linux-mtd
The build rule for mkfs.ubifs was missing an LDFLAGS_* variable like
mkfs.jffs2 had. This prevented mkfs.ubifs from being built against
explicit external libraries which is needed when cross-compiling.
This also adds UUIDCPPFLAGS and UUIDLDFLAGS variables to support the
mkfs.ubifs build.
Signed-off-by: Aaron Sierra <asierra@xes-inc.com>
---
Makefile | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index bf57a13..4ff8a49 100644
--- a/Makefile
+++ b/Makefile
@@ -3,7 +3,7 @@
VERSION = 1.5.0
-CPPFLAGS += -D_GNU_SOURCE -I./include -I$(BUILDDIR)/include -I./ubi-utils/include $(ZLIBCPPFLAGS) $(LZOCPPFLAGS)
+CPPFLAGS += -D_GNU_SOURCE -I./include -I$(BUILDDIR)/include -I./ubi-utils/include $(ZLIBCPPFLAGS) $(LZOCPPFLAGS) $(UUIDCPPFLAGS)
ifeq ($(WITHOUT_XATTR), 1)
CPPFLAGS += -DWITHOUT_XATTR
@@ -104,6 +104,7 @@ $(call _mkdep,lib/,libmtd.a)
#
obj-mkfs.ubifs = crc16.o lpt.o compr.o devtable.o \
hashtable/hashtable.o hashtable/hashtable_itr.o
+LDFLAGS_mkfs.ubifs = $(ZLIBLDFLAGS) $(LZOLDFLAGS) $(UUIDLDFLAGS)
LDLIBS_mkfs.ubifs = -lz -llzo2 -lm -luuid
$(call mkdep,mkfs.ubifs/,mkfs.ubifs,,ubi-utils/libubi.a)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mtd-utils: Makefile: add LDFLAGS_mkfs.ubifs
2013-09-27 16:34 ` [PATCH] mtd-utils: Makefile: add LDFLAGS_mkfs.ubifs Aaron Sierra
@ 2013-10-26 10:26 ` Artem Bityutskiy
0 siblings, 0 replies; 2+ messages in thread
From: Artem Bityutskiy @ 2013-10-26 10:26 UTC (permalink / raw)
To: Aaron Sierra; +Cc: linux-mtd
On Fri, 2013-09-27 at 11:34 -0500, Aaron Sierra wrote:
> The build rule for mkfs.ubifs was missing an LDFLAGS_* variable like
> mkfs.jffs2 had. This prevented mkfs.ubifs from being built against
> explicit external libraries which is needed when cross-compiling.
>
> This also adds UUIDCPPFLAGS and UUIDLDFLAGS variables to support the
> mkfs.ubifs build.
>
> Signed-off-by: Aaron Sierra <asierra@xes-inc.com>
Looks good, pushed to mtd-utils.git, thank you!
--
Best Regards,
Artem Bityutskiy
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-10-26 10:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <0e757815-7fea-4f97-858a-9f110851b86f@zimbra>
2013-09-27 16:34 ` [PATCH] mtd-utils: Makefile: add LDFLAGS_mkfs.ubifs Aaron Sierra
2013-10-26 10:26 ` Artem Bityutskiy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).