From: Artem Bityutskiy <dedekind1@gmail.com>
To: Richard Weinberger <richard.weinberger@gmail.com>
Cc: gutemine <gutemine@oozoon.de>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
Florian Fainelli <florian@openwrt.org>
Subject: Re: Patching mkfs.ubifs.c for running under Windows ?
Date: Tue, 29 Oct 2013 17:20:43 +0200 [thread overview]
Message-ID: <1383060043.29619.54.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <CAFLxGvyt2w31v7v1cmvKBE6=hLkY1G-v31srsoQz82ktxg7SAg@mail.gmail.com>
On Mon, 2013-10-28 at 11:47 +0100, Richard Weinberger wrote:
> > https://dev.openwrt.org/browser/trunk/tools/mtd-utils/patches
> >
> > in particular:
> > https://dev.openwrt.org/browser/trunk/tools/mtd-utils/patches/110-portability.patch
> > https://dev.openwrt.org/browser/trunk/tools/mtd-utils/patches/120-cygwin_fixes.patch
> > https://dev.openwrt.org/browser/trunk/tools/mtd-utils/patches/134-freebsd_loff_t.patch
> >
> > Not sure how acceptable they look like to you?
>
> Looks not that bad. :-)
> But why do you need the file "include/cygwin/bits-byteswap.h"?
>
> Artem, what do you think?
> IMHO adding cygwin support is less intrusive than adding native win32 support.
I would clean-up these patches even more, and split them further. But
yes, it looks like these could be turned into something not so intrusive
and maintainable and be merged if MTD users need them.
--
Best Regards,
Artem Bityutskiy
prev parent reply other threads:[~2013-10-29 15:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mailman.6.1379692801.23497.linux-mtd@lists.infradead.org>
2013-09-21 10:58 ` Patching mkfs.ubifs.c for running under Windows ? gutemine
2013-09-21 22:46 ` richard -rw- weinberger
2013-09-22 9:19 ` gutemine
2013-09-22 9:26 ` Richard Weinberger
2013-09-22 10:00 ` gutemine
2013-09-22 10:02 ` Richard Weinberger
2013-09-22 10:08 ` gutemine
2013-10-26 10:17 ` Artem Bityutskiy
2013-10-28 1:38 ` Florian Fainelli
2013-10-28 10:47 ` Richard Weinberger
2013-10-29 15:20 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383060043.29619.54.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=florian@openwrt.org \
--cc=gutemine@oozoon.de \
--cc=linux-mtd@lists.infradead.org \
--cc=richard.weinberger@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox