From: "Alexander Shiyan" <shc_work@mail.ru>
To: "Ezequiel Garcia" <ezequiel.garcia@free-electrons.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mtd: nand: gpio: Remove unneeded CONFIG_OF
Date: Sat, 07 Dec 2013 18:54:32 +0400 [thread overview]
Message-ID: <1386428072.693656580@f164.i.mail.ru> (raw)
In-Reply-To: <1386427686-30190-1-git-send-email-ezequiel.garcia@free-electrons.com>
Hello.
> Since the of_mtd header provides dummy stubs for !CONFIG_OF, it's safe
> to remove the #ifdef CONFIG_OF. Build tested only.
>
> Cc: Alexander Shiyan <shc_work@mail.ru>
> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
...
> -#ifdef CONFIG_OF
> static const struct of_device_id gpio_nand_id_table[] = {
You should add "__maybe_unused" attribute here in this case.
This will avoid warning when you build driver without OF.
---
next prev parent reply other threads:[~2013-12-07 14:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-07 14:48 [PATCH] mtd: nand: gpio: Remove unneeded CONFIG_OF Ezequiel Garcia
2013-12-07 14:54 ` Alexander Shiyan [this message]
2013-12-07 15:33 ` Ezequiel Garcia
2013-12-07 15:35 ` Alexander Shiyan
2013-12-07 15:40 ` Ezequiel Garcia
2013-12-07 15:43 ` Alexander Shiyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386428072.693656580@f164.i.mail.ru \
--to=shc_work@mail.ru \
--cc=ezequiel.garcia@free-electrons.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox