linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Elie De Brauwer <eliedebrauwer@gmail.com>
To: b32955@freescale.com, dwmw2@infradead.org, dedekind1@gmail.com,
	computersforpeace@gmail.com, shijie8@gmail.com
Cc: Elie De Brauwer <eliedebrauwer@gmail.com>, linux-mtd@lists.infradead.org
Subject: [PATCH v3] mtd: gpmi: Bitflip support in erased regions
Date: Tue, 17 Dec 2013 07:59:40 +0100	[thread overview]
Message-ID: <1387263581-7863-1-git-send-email-eliedebrauwer@gmail.com> (raw)

Hello All,

This is v3 of my patch which adds support for bitflip detection/correction
in erased regions when using BCH/GPMI nand.

Changes in V3:
 - The fast path in V2 was not entered (my bad, I mixed some boards when
testing) due to using a faulty register offset. The fast path implemention
for correctly reading fully erased blocks is now functional (and properly 
tested). 
 - Also the fast path even become a bit faster since we now break out of
the for loop as soon as we see a properly erased block (instead of briefly
touching all sectors).
 - The ERASE_THRESHOLD aka the number of bitflips in erased regions we 
tolerate is no longer set to ecc_strength but to gf_len/2.
 - Several cosmetic changes.

Main credit to the above goes to Huang Shijie, thanks a lot !

Further comments/feedback welcome, but at this point I don't see any other
open points.

E.


Elie De Brauwer (1):
  mtd: gpmi: Deal with bitflips in erased regions regions

 drivers/mtd/nand/gpmi-nand/bch-regs.h  |    2 ++
 drivers/mtd/nand/gpmi-nand/gpmi-lib.c  |   16 ++++++++++++
 drivers/mtd/nand/gpmi-nand/gpmi-nand.c |   44 +++++++++++++++++++++++++++++---
 drivers/mtd/nand/gpmi-nand/gpmi-nand.h |    1 +
 4 files changed, 60 insertions(+), 3 deletions(-)

-- 
1.7.10.4

             reply	other threads:[~2013-12-17  7:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-17  6:59 Elie De Brauwer [this message]
2013-12-17  6:59 ` [PATCH v3] mtd: gpmi: Deal with bitflips in erased regions regions Elie De Brauwer
2013-12-17  6:56   ` Huang Shijie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1387263581-7863-1-git-send-email-eliedebrauwer@gmail.com \
    --to=eliedebrauwer@gmail.com \
    --cc=b32955@freescale.com \
    --cc=computersforpeace@gmail.com \
    --cc=dedekind1@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=shijie8@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).