From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
To: "Gupta, Pekon" <pekon@ti.com>
Cc: "u-boot@lists.denx.de" <u-boot@lists.denx.de>,
"Stefan Roese <sr@denx.de> \(sr@denx.de\)" <sr@denx.de>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
Calvin Johnson <linux.cj@gmail.com>
Subject: Re: UBIFS seeing corrupt blank pages when image flashed via u-boot
Date: Thu, 16 Jan 2014 10:22:58 +0200 [thread overview]
Message-ID: <1389860578.26808.90.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <20980858CB6D3A4BAE95CA194937D5E73EA62464@DBDE04.ent.ti.com>
On Thu, 2014-01-16 at 07:44 +0000, Gupta, Pekon wrote:
> However, *assuming NAND driver can identify erased-page correctly*,
> I don't want UBI/UBIFS to re-check the read_buf for 0xff again, because
> underlying NAND driver has already identified as erased-page, and
> fixed the data before passing it to above MTD layer.
I would agree only if this identification costs nothing, or very little.
If for _some_ setups this would be about comparing buffers against 0xFF
for every single read - then I am so sure.
Indeed, UBIFS only needs to check for blank areas at the recovery time.
Normal reads do not need this. So _if_ there are measurable costs, I'd
argue that there is no need for people to pay it for nothing during
normal file I/O.
Hmm?
Thanks!
--
Best Regards,
Artem Bityutskiy
prev parent reply other threads:[~2014-01-16 8:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-03 11:45 UBIFS seeing corrupt blank pages when image flashed via u-boot Gupta, Pekon
2014-01-03 12:59 ` Artem Bityutskiy
2014-01-03 13:05 ` Bityutskiy, Artem
2014-01-03 14:04 ` Stefano Babic
2014-01-07 17:30 ` Gupta, Pekon
2014-01-13 12:19 ` Calvin Johnson
2014-01-13 12:58 ` Artem Bityutskiy
2014-01-13 13:16 ` Gupta, Pekon
2014-01-13 15:06 ` Artem Bityutskiy
2014-01-15 21:29 ` Gupta, Pekon
2014-01-16 7:19 ` Artem Bityutskiy
2014-01-16 7:44 ` Gupta, Pekon
2014-01-16 8:22 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389860578.26808.90.camel@sauron.fi.intel.com \
--to=artem.bityutskiy@linux.intel.com \
--cc=linux-mtd@lists.infradead.org \
--cc=linux.cj@gmail.com \
--cc=pekon@ti.com \
--cc=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).