Re: [PATCH 1/1] ubi: Introduce block devices for UBI volumes

[Artem Bityutskiy <dedekind1@gmail.com>]

Ezequiel,

first of all, thanks for the driver.

On Sun, 2014-02-09 at 23:48 -0300, Ezequiel Garcia wrote:
> On Sun, Feb 09, 2014 at 08:51:57AM +0100, Willy Tarreau wrote:
> [..]
> > 
> > > > This I think it's a bad idea to artificially remove some features
> > > > if they're not broken.
> > > 
> > > Your arguments have convinced me, let's keep it and hope the best.
> > 
> 
> Let me add that keeping the write support follows the whole "mechanism,
> not policy" kernel motto, doesn't it?
> 
> Regarding users, well the option looks like this:
> 
>   [ ]     Enable write support (DANGEROUS)
> 
> I think any user would think twice before enabling it.

Linus and Andrew usually ask reasonable questions like these for new
features. I'd like to ask them for the write feature.

Who are the customers for these?
How are the user of the write feature? How many?
Have it been tested? If yes, how?

These are really the things which define whether the feature should be
in or not, I think.

If write support has 0 or 1.5 customers and it was not tested
extensively, and never used in any kind of production, I am not sure it
is needed to be there. But let's first hear your answers.

It is simple is not good argument. It will be as simple to add it too.

WRT to DANGEROUS sign, people do not read Kconfig help. Some distro will
just enable this, people will start using this, and then start sending
unappy e-mails. We have this with MTD block. No matter how many times I
wrote to people that this is just a debugging module, they still kept
using it.

If this is about really few lines of code, the alternative would be to
leave them there, but just disable, and remove the Kconfig part. If
someone needs write support and starts looking inside the driver, he/she
will notice the code and start playing with that.

-- 
Best Regards,
Artem Bityutskiy