Linux-mtd Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Huang Shijie <b32955@freescale.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH resend] ubi: attach: do not return -EINVAL if the mtd->numeraseregions is 1
Date: Fri, 14 Feb 2014 11:18:52 +0200	[thread overview]
Message-ID: <1392369532.12215.61.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <1392365295-19299-1-git-send-email-b32955@freescale.com>

On Fri, 2014-02-14 at 16:08 +0800, Huang Shijie wrote:
> If the master mtd does not have any slave mtd partitions,
> and its numeraseregions is one(only has one erease block), and
> we attach the master mtd with : ubiattach -m 0 -d 0
> 
> We will meet the error with (Micron M29W256GL7AN6):
> -------------------------------------------------------
> root@freescale ~$ ubiattach /dev/ubi_ctrl -m 0 -d 0
> UBI: attaching mtd0 to ubi0
> UBI error: io_init: multiple regions, not implemented
> ubiattach: error!: cannot attach mtd0
>            error 22 (Invalid argument)
> -------------------------------------------------------
> 
> In fact, if there is only one "erase block", we should not
> prevent the attach.
> 
> This patch fixes it.
> 
> Signed-off-by: Huang Shijie <b32955@freescale.com>

Did you investigate the entire MTD subsystem an figure out what exactly
'numeraseregions=0' and 'numeraseregions=1' mean? What is the difference
between these 2. Is there consistency?

E.g., if 'numeraseregions=1' should there be non-NULL
'mtd->eraseregions'? What UBI should do with that then?

I am fine to apply your patch, but I would like to understand the whole
'erase regions' thing - what is this, what exactly are the semantics,
how UBI should use them, etc.

So far, for me 'numeraseregions=0' means there is no erase regions, and
this is what all drivers UBI has been working so far have.

I have no idea what are 'numeraseregions=1' beats, and how to deal with
them.

Ideally, I'd love to see a repsons to this e-mail like this:


From: Huang Shijie <b32955@freescale.com>, 
Subject: mtd-www: document erase regions

This patch is against the mtd-www project and it adds a piece of
documentation about MTD erase regions.


:-)

Thanks!

-- 
Best Regards,
Artem Bityutskiy

  reply	other threads:[~2014-02-14  9:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-14  8:08 [PATCH resend] ubi: attach: do not return -EINVAL if the mtd->numeraseregions is 1 Huang Shijie
2014-02-14  9:18 ` Artem Bityutskiy [this message]
2014-02-14  9:11   ` Huang Shijie
2014-02-14 11:22     ` Artem Bityutskiy
2014-02-19 11:40       ` Huang Shijie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1392369532.12215.61.camel@sauron.fi.intel.com \
    --to=dedekind1@gmail.com \
    --cc=b32955@freescale.com \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox