public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: tiantao <tiantao6@huawei.com>
Cc: Tian Tao <tiantao6@hisilicon.com>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	 linux-mtd <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH] mtd: core: Convert sysfs sprintf/snprintf family to sysfs_emit
Date: Mon, 12 Apr 2021 10:25:52 +0200 (CEST)	[thread overview]
Message-ID: <1392900373.173016.1618215952396.JavaMail.zimbra@nod.at> (raw)
In-Reply-To: <009e80a0-8aaa-4824-10c4-a5a82b2c6528@huawei.com>

----- Ursprüngliche Mail -----
> understand.
> 
> What do you think of the following commit message
> 
> Use sysfs_emit instead of snprintf to avoid buf overrun,because in
> sysfs_emit it strictly checks
> 
> whether buf is null or buf whether pagesize aligned, otherwise it
> returns an error.

This makes perfectly sense! :-)
Additional you can also not that this issue was found by coccicheck.

Thanks,
//richard

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2021-04-12  8:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-12  6:44 [PATCH] mtd: core: Convert sysfs sprintf/snprintf family to sysfs_emit Tian Tao
2021-04-12  6:49 ` Richard Weinberger
     [not found]   ` <049f8110-5777-db77-d374-275d1ceee81d@huawei.com>
2021-04-12  8:07     ` Richard Weinberger
2021-04-12  8:17       ` tiantao (H)
2021-04-12  8:25         ` Richard Weinberger [this message]
2021-04-12  8:29           ` tiantao (H)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1392900373.173016.1618215952396.JavaMail.zimbra@nod.at \
    --to=richard@nod.at \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=tiantao6@hisilicon.com \
    --cc=tiantao6@huawei.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox