From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qg0-x22b.google.com ([2607:f8b0:400d:c04::22b]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WYghE-0005P1-PN for linux-mtd@lists.infradead.org; Fri, 11 Apr 2014 19:01:05 +0000 Received: by mail-qg0-f43.google.com with SMTP id f51so5929781qge.30 for ; Fri, 11 Apr 2014 12:00:45 -0700 (PDT) From: Brian Norris To: Subject: [PATCH v3 11/11] mtd: fsl-quadspi: fix __iomem annotations, accessors Date: Fri, 11 Apr 2014 12:00:06 -0700 Message-Id: <1397242806-7575-12-git-send-email-computersforpeace@gmail.com> In-Reply-To: <1397242806-7575-1-git-send-email-computersforpeace@gmail.com> References: <1397242806-7575-1-git-send-email-computersforpeace@gmail.com> Cc: Marek Vasut , Huang Shijie , Brian Norris , Lee Jones List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , This corrects some sparse warnings: drivers/mtd/spi-nor/fsl-quadspi.c:281:31: warning: incorrect type in initializer (different address spaces) [sparse] drivers/mtd/spi-nor/fsl-quadspi.c:281:31: expected void *[noderef] base [sparse] drivers/mtd/spi-nor/fsl-quadspi.c:281:31: got void [noderef] *iobase [sparse] (etc.) and drivers/mtd/spi-nor/fsl-quadspi.c:733:53: warning: incorrect type in argument 2 (different address spaces) drivers/mtd/spi-nor/fsl-quadspi.c:733:53: expected void const * drivers/mtd/spi-nor/fsl-quadspi.c:733:53: got void [noderef] * Signed-off-by: Brian Norris --- new in v3 drivers/mtd/spi-nor/fsl-quadspi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c b/drivers/mtd/spi-nor/fsl-quadspi.c index b41bbbc531ff..e85046e734e4 100644 --- a/drivers/mtd/spi-nor/fsl-quadspi.c +++ b/drivers/mtd/spi-nor/fsl-quadspi.c @@ -278,7 +278,7 @@ static irqreturn_t fsl_qspi_irq_handler(int irq, void *dev_id) static void fsl_qspi_init_lut(struct fsl_qspi *q) { - void *__iomem base = q->iobase; + void __iomem *base = q->iobase; int rxfifo = q->devtype_data->rxfifo; u32 lut_base; u8 cmd, addrlen, dummy; @@ -422,7 +422,7 @@ static int fsl_qspi_get_seqid(struct fsl_qspi *q, u8 cmd) static int fsl_qspi_runcmd(struct fsl_qspi *q, u8 cmd, unsigned int addr, int len) { - void *__iomem base = q->iobase; + void __iomem *base = q->iobase; int seqid; u32 reg, reg2; int err; @@ -730,7 +730,7 @@ static int fsl_qspi_read(struct spi_nor *nor, loff_t from, return ret; /* Read out the data directly from the AHB buffer.*/ - memcpy(buf, q->ahb_base + q->chip_base_addr + from, len); + memcpy_fromio(buf, q->ahb_base + q->chip_base_addr + from, len); *retlen += len; return 0; -- 1.8.3.2