From: Artem Bityutskiy <dedekind1@gmail.com>
To: "Mats Kärrman" <Mats.Karrman@tritech.se>
Cc: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH 2/2] mtd-utils: integck: add support for volume specific power-cut test
Date: Tue, 15 Apr 2014 16:12:12 +0300 [thread overview]
Message-ID: <1397567532.4441.9.camel@karhu> (raw)
In-Reply-To: <ED3E0BCACD909541BA94A34C4A164D4C5B3D11F5@post.tritech.se>
Hi Mats,
pushed the first patch out, thanks.
On Mon, 2014-04-14 at 11:47 +0000, Mats Kärrman wrote:
> -"continues forever.\n";
> +"continues forever.\n"
> +"Whereas -p requires power cut emulation to be enabled globally, the -P option\n"
> +"automatically enables the use of power cut emulation on the tested fs instance\n"
> +"only (currently implemented for UBIFS only).\n";
Could we please invent an easy to understand way of naming this and the
option.
So essentially, this is about emulating power cuts at UBI and UBIFS
levels. The "reenabling" thing is a small details which should not be
visible in --help, because it is confusing anyway.
I'd suggest to split this patch on 2. First patch renames the option to
'--ubi-power-cut', refines help message, may be some comments and
function names, if needed.
The second patch introduces '--ubifs-power-cut', and explains that this
makes sure that power cuts happen in the UBIFS driver, versus the
underlying UBI driver.
Thanks!
--
Best Regards,
Artem Bityutskiy
next prev parent reply other threads:[~2014-04-15 13:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 11:47 [PATCH 2/2] mtd-utils: integck: add support for volume specific power-cut test Mats Kärrman
2014-04-15 13:12 ` Artem Bityutskiy [this message]
2014-04-15 15:07 ` Mats Kärrman
2014-05-13 9:29 ` Mats Kärrman
2014-05-13 11:00 ` Artem Bityutskiy
2014-05-13 12:59 ` Mats Kärrman
2014-05-13 13:31 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1397567532.4441.9.camel@karhu \
--to=dedekind1@gmail.com \
--cc=Mats.Karrman@tritech.se \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox