From: Artem Bityutskiy <dedekind1@gmail.com>
To: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Cc: "Brian Norris" <computersforpeace@gmail.com>,
linux-mtd@lists.infradead.org,
"Guido Martínez" <guido@vanguardiasur.com.ar>
Subject: Re: [PATCH 3/3] nandtest: Introduce multiple reads & check iterations
Date: Mon, 05 May 2014 10:35:04 +0300 [thread overview]
Message-ID: <1399275304.15290.15.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <1398690859-11494-4-git-send-email-ezequiel@vanguardiasur.com.ar>
On Mon, 2014-04-28 at 10:14 -0300, Ezequiel Garcia wrote:
> }
> - if (erase_and_write(test_ofs, wbuf, rbuf))
> + if (erase_and_write(test_ofs, wbuf, rbuf,
> nr_reads))
> continue;
> if (keep_contents)
> - erase_and_write(test_ofs, kbuf, rbuf);
> + erase_and_write(test_ofs, kbuf, rbuf,
> 1);
I think it would make sense to make the default to be at least 2, or may
be 4.
If you added this improvement, let's make sure people have it on by
default.
--
Best Regards,
Artem Bityutskiy
next prev parent reply other threads:[~2014-05-05 7:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-28 13:14 [PATCH 0/3] nandtest: Allow multiple read & check iterations Ezequiel Garcia
2014-04-28 13:14 ` [PATCH 1/3] nandtest: Remove redundant check Ezequiel Garcia
2014-05-05 7:30 ` Artem Bityutskiy
2014-04-28 13:14 ` [PATCH 2/3] nandtest: Move the "read and compare" code to a function Ezequiel Garcia
2014-05-05 7:36 ` Artem Bityutskiy
2014-04-28 13:14 ` [PATCH 3/3] nandtest: Introduce multiple reads & check iterations Ezequiel Garcia
2014-05-05 7:35 ` Artem Bityutskiy [this message]
2014-05-05 9:56 ` Ezequiel García
2014-05-05 10:07 ` Gupta, Pekon
2014-05-05 10:33 ` Ezequiel Garcia
2014-05-05 10:58 ` Gupta, Pekon
2014-05-05 11:09 ` Artem Bityutskiy
2014-05-05 11:21 ` Gupta, Pekon
2014-05-05 12:50 ` Problems in Out of tree TI SDK omap2-nand driver (Re: [PATCH 3/3] nandtest: Introduce multiple reads & check iterations) Ezequiel Garcia
2014-05-05 18:12 ` Gupta, Pekon
2014-05-30 23:49 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399275304.15290.15.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=computersforpeace@gmail.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=guido@vanguardiasur.com.ar \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox