From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com ([134.134.136.20]) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1WhGmH-0002Yy-7D for linux-mtd@lists.infradead.org; Mon, 05 May 2014 11:09:45 +0000 Message-ID: <1399288152.15290.21.camel@sauron.fi.intel.com> Subject: Re: [PATCH 3/3] nandtest: Introduce multiple reads & check iterations From: Artem Bityutskiy To: "Gupta, Pekon" Date: Mon, 05 May 2014 14:09:12 +0300 In-Reply-To: <20980858CB6D3A4BAE95CA194937D5E73EACA6B9@DBDE04.ent.ti.com> References: <1398690859-11494-1-git-send-email-ezequiel@vanguardiasur.com.ar> <1398690859-11494-4-git-send-email-ezequiel@vanguardiasur.com.ar> <20980858CB6D3A4BAE95CA194937D5E73EACA5DB@DBDE04.ent.ti.com> <20140505103335.GF2873@arch.cereza> <20980858CB6D3A4BAE95CA194937D5E73EACA6B9@DBDE04.ent.ti.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Cc: Brian Norris , "linux-mtd@lists.infradead.org" , Ezequiel Garcia , Guido =?ISO-8859-1?Q?Mart=EDnez?= Reply-To: dedekind1@gmail.com List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 2014-05-05 at 10:58 +0000, Gupta, Pekon wrote: > Therefore, I'm not sure having re-reads is a good test or not, because > re-reads is changing the underlying testing scenario by introducing > _new_ > bit-flips in neighboring regions pages because of read-disturbs. If the driver / HW cannot properly handle 4 re-reads, we do want the test to catch this, I think, irrespective of the true nature of the error. Therefore, I see this patch with a default 4 as an improvement. -- Best Regards, Artem Bityutskiy