From: Marek Vasut <marek.vasut@gmail.com>
To: Alexander Kurz <akurz@blala.de>,
Cyrille Pitchen <cyrille.pitchen@atmel.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Richard Weinberger <richard@nod.at>,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH v2] drivers mtd: spi-nor: add new variants
Date: Fri, 10 Mar 2017 04:42:40 +0100 [thread overview]
Message-ID: <13bcdcc3-8a7b-3cba-d69d-110fa948a7c3@gmail.com> (raw)
In-Reply-To: <1488491946-12176-1-git-send-email-akurz@blala.de>
On 03/02/2017 10:59 PM, Alexander Kurz wrote:
> Macronix MX25U4035 and Winbond 25Q20BW devices are used in 4/5th
> generation Kindle ebook readers. Add those spi-nor variants.
> Also add similar devices found in the same datasheets.
It'd be nice to split it into two separate patches, each one adding one
manufacturer of devices and having $subject reflect that. Otherwise it's
IMO OK.
> Signed-off-by: Alexander Kurz <akurz@blala.de>
> ---
> drivers/mtd/spi-nor/spi-nor.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index 1ae872b..802dc49 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -1013,6 +1013,8 @@ static const struct flash_info spi_nor_ids[] = {
> { "mx25l3205d", INFO(0xc22016, 0, 64 * 1024, 64, SECT_4K) },
> { "mx25l3255e", INFO(0xc29e16, 0, 64 * 1024, 64, SECT_4K) },
> { "mx25l6405d", INFO(0xc22017, 0, 64 * 1024, 128, SECT_4K) },
> + { "mx25u4035", INFO(0xc22533, 0, 64 * 1024, 8, SECT_4K) },
> + { "mx25u8035", INFO(0xc22534, 0, 64 * 1024, 16, SECT_4K) },
> { "mx25u6435f", INFO(0xc22537, 0, 64 * 1024, 128, SECT_4K) },
> { "mx25l12805d", INFO(0xc22018, 0, 64 * 1024, 256, 0) },
> { "mx25l12855e", INFO(0xc22618, 0, 64 * 1024, 256, 0) },
> @@ -1128,6 +1130,9 @@ static const struct flash_info spi_nor_ids[] = {
> { "w25x80", INFO(0xef3014, 0, 64 * 1024, 16, SECT_4K) },
> { "w25x16", INFO(0xef3015, 0, 64 * 1024, 32, SECT_4K) },
> { "w25x32", INFO(0xef3016, 0, 64 * 1024, 64, SECT_4K) },
> + { "w25q20cl", INFO(0xef4012, 0, 64 * 1024, 4, SECT_4K) },
> + { "w25q20bw", INFO(0xef5012, 0, 64 * 1024, 4, SECT_4K) },
> + { "w25q20ew", INFO(0xef6012, 0, 64 * 1024, 4, SECT_4K) },
> { "w25q32", INFO(0xef4016, 0, 64 * 1024, 64, SECT_4K) },
> {
> "w25q32dw", INFO(0xef6016, 0, 64 * 1024, 64,
>
--
Best regards,
Marek Vasut
prev parent reply other threads:[~2017-03-10 3:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-02 21:59 [PATCH v2] drivers mtd: spi-nor: add new variants Alexander Kurz
2017-03-10 3:42 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13bcdcc3-8a7b-3cba-d69d-110fa948a7c3@gmail.com \
--to=marek.vasut@gmail.com \
--cc=akurz@blala.de \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@atmel.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox