* [PATCH] mtd: lpddr: fix Kconfig dependency, for I/O accessors
@ 2014-05-21 20:29 Brian Norris
2014-05-26 17:43 ` Brian Norris
2014-05-26 22:16 ` Vincenzo Aliberti
0 siblings, 2 replies; 3+ messages in thread
From: Brian Norris @ 2014-05-21 20:29 UTC (permalink / raw)
To: linux-mtd; +Cc: Brian Norris, Vincenzo Aliberti
Not all architectures implement a writel_relaxed() accessor. Hopefully
this will change eventually, but for now, this means lpddr2_nvm.c can't
compile on some architectures.
Let's add an ARM dependency for now, and leave a comment so maybe we can
change this in the future.
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Cc: Vincenzo Aliberti <vincenzo.aliberti@gmail.com>
---
drivers/mtd/lpddr/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mtd/lpddr/Kconfig b/drivers/mtd/lpddr/Kconfig
index 468f06dea45d..3a19cbee24d7 100644
--- a/drivers/mtd/lpddr/Kconfig
+++ b/drivers/mtd/lpddr/Kconfig
@@ -19,7 +19,8 @@ config MTD_QINFO_PROBE
Flash products
config MTD_LPDDR2_NVM
- depends on MTD
+ # ARM dependency is only for writel_relaxed()
+ depends on MTD && ARM
tristate "Support for LPDDR2-NVM flash chips"
help
This option enables support of PCM memories with a LPDDR2-NVM
--
1.8.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: lpddr: fix Kconfig dependency, for I/O accessors
2014-05-21 20:29 [PATCH] mtd: lpddr: fix Kconfig dependency, for I/O accessors Brian Norris
@ 2014-05-26 17:43 ` Brian Norris
2014-05-26 22:16 ` Vincenzo Aliberti
1 sibling, 0 replies; 3+ messages in thread
From: Brian Norris @ 2014-05-26 17:43 UTC (permalink / raw)
To: linux-mtd; +Cc: Vincenzo Aliberti
On Wed, May 21, 2014 at 01:29:13PM -0700, Brian Norris wrote:
> Not all architectures implement a writel_relaxed() accessor. Hopefully
> this will change eventually, but for now, this means lpddr2_nvm.c can't
> compile on some architectures.
>
> Let's add an ARM dependency for now, and leave a comment so maybe we can
> change this in the future.
>
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> Cc: Vincenzo Aliberti <vincenzo.aliberti@gmail.com>
Pushed to l2-mtd.git, to stop people from reporting build failures on
x86.
Brian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: lpddr: fix Kconfig dependency, for I/O accessors
2014-05-21 20:29 [PATCH] mtd: lpddr: fix Kconfig dependency, for I/O accessors Brian Norris
2014-05-26 17:43 ` Brian Norris
@ 2014-05-26 22:16 ` Vincenzo Aliberti
1 sibling, 0 replies; 3+ messages in thread
From: Vincenzo Aliberti @ 2014-05-26 22:16 UTC (permalink / raw)
To: Brian Norris; +Cc: linux-mtd
Brian,
as discussed this solution is fine for me
Vincenzo
On Wed, May 21, 2014 at 10:29 PM, Brian Norris
<computersforpeace@gmail.com> wrote:
> Not all architectures implement a writel_relaxed() accessor. Hopefully
> this will change eventually, but for now, this means lpddr2_nvm.c can't
> compile on some architectures.
>
> Let's add an ARM dependency for now, and leave a comment so maybe we can
> change this in the future.
>
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> Cc: Vincenzo Aliberti <vincenzo.aliberti@gmail.com>
> ---
> drivers/mtd/lpddr/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/lpddr/Kconfig b/drivers/mtd/lpddr/Kconfig
> index 468f06dea45d..3a19cbee24d7 100644
> --- a/drivers/mtd/lpddr/Kconfig
> +++ b/drivers/mtd/lpddr/Kconfig
> @@ -19,7 +19,8 @@ config MTD_QINFO_PROBE
> Flash products
>
> config MTD_LPDDR2_NVM
> - depends on MTD
> + # ARM dependency is only for writel_relaxed()
> + depends on MTD && ARM
> tristate "Support for LPDDR2-NVM flash chips"
> help
> This option enables support of PCM memories with a LPDDR2-NVM
> --
> 1.8.3.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-05-26 22:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-21 20:29 [PATCH] mtd: lpddr: fix Kconfig dependency, for I/O accessors Brian Norris
2014-05-26 17:43 ` Brian Norris
2014-05-26 22:16 ` Vincenzo Aliberti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox