* [PATCH] mtd: maps: remove check for CONFIG_MTD_SUPERH_RESERVE
@ 2014-05-23 14:29 Paul Bolle
2014-05-28 22:33 ` Brian Norris
0 siblings, 1 reply; 2+ messages in thread
From: Paul Bolle @ 2014-05-23 14:29 UTC (permalink / raw)
To: David Woodhouse, Brian Norris; +Cc: linux-mtd, linux-kernel
Since (a few releases before) v2.6.0 there have been checks for
CONFIG_MTD_SUPERH_RESERVE. One check is still present. But a Kconfig
symbol MTD_SUPERH_RESERVE has never been added. So a few lines of dead
code can be removed.
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
Untested.
drivers/mtd/maps/solutionengine.c | 25 +------------------------
1 file changed, 1 insertion(+), 24 deletions(-)
diff --git a/drivers/mtd/maps/solutionengine.c b/drivers/mtd/maps/solutionengine.c
index 83a7a7091562..bb580bc16445 100644
--- a/drivers/mtd/maps/solutionengine.c
+++ b/drivers/mtd/maps/solutionengine.c
@@ -33,28 +33,6 @@ struct map_info soleng_flash_map = {
static const char * const probes[] = { "RedBoot", "cmdlinepart", NULL };
-#ifdef CONFIG_MTD_SUPERH_RESERVE
-static struct mtd_partition superh_se_partitions[] = {
- /* Reserved for boot code, read-only */
- {
- .name = "flash_boot",
- .offset = 0x00000000,
- .size = CONFIG_MTD_SUPERH_RESERVE,
- .mask_flags = MTD_WRITEABLE,
- },
- /* All else is writable (e.g. JFFS) */
- {
- .name = "Flash FS",
- .offset = MTDPART_OFS_NXTBLK,
- .size = MTDPART_SIZ_FULL,
- }
-};
-#define NUM_PARTITIONS ARRAY_SIZE(superh_se_partitions)
-#else
-#define superh_se_partitions NULL
-#define NUM_PARTITIONS 0
-#endif /* CONFIG_MTD_SUPERH_RESERVE */
-
static int __init init_soleng_maps(void)
{
/* First probe at offset 0 */
@@ -92,8 +70,7 @@ static int __init init_soleng_maps(void)
mtd_device_register(eprom_mtd, NULL, 0);
}
- mtd_device_parse_register(flash_mtd, probes, NULL,
- superh_se_partitions, NUM_PARTITIONS);
+ mtd_device_parse_register(flash_mtd, probes, NULL, NULL, 0);
return 0;
}
--
1.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mtd: maps: remove check for CONFIG_MTD_SUPERH_RESERVE
2014-05-23 14:29 [PATCH] mtd: maps: remove check for CONFIG_MTD_SUPERH_RESERVE Paul Bolle
@ 2014-05-28 22:33 ` Brian Norris
0 siblings, 0 replies; 2+ messages in thread
From: Brian Norris @ 2014-05-28 22:33 UTC (permalink / raw)
To: Paul Bolle; +Cc: linux-mtd, David Woodhouse, linux-kernel
On Fri, May 23, 2014 at 04:29:54PM +0200, Paul Bolle wrote:
> Since (a few releases before) v2.6.0 there have been checks for
> CONFIG_MTD_SUPERH_RESERVE. One check is still present. But a Kconfig
> symbol MTD_SUPERH_RESERVE has never been added. So a few lines of dead
> code can be removed.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> Untested.
Compile-tested and pushed to l2-mtd.git. Thanks!
Brian
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-28 22:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-23 14:29 [PATCH] mtd: maps: remove check for CONFIG_MTD_SUPERH_RESERVE Paul Bolle
2014-05-28 22:33 ` Brian Norris
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).