From: Artem Bityutskiy <dedekind1@gmail.com>
To: hujianyang <hujianyang@huawei.com>
Cc: linux-mtd <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH] ubifs: add missing ui pointer in debugging code
Date: Wed, 28 May 2014 11:04:50 +0300 [thread overview]
Message-ID: <1401264290.983.15.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <53854980.2000204@huawei.com>
On Wed, 2014-05-28 at 10:27 +0800, hujianyang wrote:
> Hi Artem,
>
> I think you made a small mistake:
Indeed, and not that small, even. I'll fix this, thanks!
If I was writing this code now, I would not bother using shifts, I'd
just use divisions, which are simpler and less error-prone. And modern
compilers are smart enough to optimize the code to use shifts when the
divider is a constant.
--
Best Regards,
Artem Bityutskiy
next prev parent reply other threads:[~2014-05-28 8:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-13 20:27 [PATCH] ubifs: add missing ui pointer in debugging code Daniel Golle
2014-05-14 7:32 ` hujianyang
2014-05-15 15:54 ` Daniel
2014-05-27 12:28 ` Artem Bityutskiy
2014-05-28 2:27 ` hujianyang
2014-05-28 8:04 ` Artem Bityutskiy [this message]
2014-05-27 12:27 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401264290.983.15.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=hujianyang@huawei.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).