Re: [PATCH v5] ubifs: respect MS_SILENT mount flag

[Artem Bityutskiy <dedekind1@gmail.com>]

Thanks Daniel, this looks nicer than the original patch. Would you
please do few more cosmetic changes, though.

On Sat, 2014-05-31 at 02:01 +0200, Daniel Golle wrote: 
> diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
> index a81c7b5..e88bbb6 100644
> --- a/fs/ubifs/super.c
> +++ b/fs/ubifs/super.c
> @@ -1149,6 +1149,8 @@ static int mount_ubifs(struct ubifs_info *c)
>  	size_t sz;
>  
>  	c->ro_mount = !!(c->vfs_sb->s_flags & MS_RDONLY);
> +	c->probing = !!(c->vfs_sb->s_flags & MS_SILENT);

Would you add a comment on top of this saying what MS_SILENT is about.
The kernel people who read the code do not necessary know the "FS
probing" use-case. E.g., I did not know about it.
> @@ -1441,6 +1451,7 @@ struct ubifs_info {
>  	unsigned int replaying:1;
>  	unsigned int mounting:1;
>  	unsigned int remounting_rw:1;
> +	unsigned int probing:1;

We have kerneldoc-style comment on top of this structure, could you
please document the new field there.

-- 
Best Regards,
Artem Bityutskiy