[PATCH 1/1] fs/ubifs/super.c: replace count*size kzalloc by kcalloc

[PATCH 1/1] fs/ubifs/super.c: replace count*size kzalloc by kcalloc

[Fabian Frederick]

kcalloc manages count*sizeof overflow.

Cc: Artem Bityutskiy <dedekind1@gmail.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: linux-mtd@lists.infradead.org
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
 fs/ubifs/super.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
index 3904c85..537b91d 100644
--- a/fs/ubifs/super.c
+++ b/fs/ubifs/super.c
@@ -796,8 +796,8 @@ static int alloc_wbufs(struct ubifs_info *c)
 {
 	int i, err;
 
-	c->jheads = kzalloc(c->jhead_cnt * sizeof(struct ubifs_jhead),
-			   GFP_KERNEL);
+	c->jheads = kcalloc(c->jhead_cnt, sizeof(struct ubifs_jhead),
+			    GFP_KERNEL);
 	if (!c->jheads)
 		return -ENOMEM;
 
-- 
1.8.4.5

Re: [PATCH 1/1] fs/ubifs/super.c: replace count*size kzalloc by kcalloc

[Artem Bityutskiy]

On Mon, 2014-06-23 at 18:41 +0200, Fabian Frederick wrote:
> kcalloc manages count*sizeof overflow.
> 
> Cc: Artem Bityutskiy <dedekind1@gmail.com>
> Cc: Adrian Hunter <adrian.hunter@intel.com>
> Cc: linux-mtd@lists.infradead.org
> Signed-off-by: Fabian Frederick <fabf@skynet.be>

In the commit message, please, try to not only tell _what_ you do,
but also _why_ you do this. And ideally, but not necessary for this
case, I think, how this was tested (e.g., compile-tested only).

Thanks! I'll apply this patch, and amend the commit message so that it
tells that kcalloc() makes better bob of the overflow checking.

-- 
Best Regards,
Artem Bityutskiy

Re: [PATCH 1/1] fs/ubifs/super.c: replace count*size kzalloc by kcalloc

[Artem Bityutskiy]

On Wed, 2014-07-16 at 09:10 +0300, Artem Bityutskiy wrote:
> On Mon, 2014-06-23 at 18:41 +0200, Fabian Frederick wrote:
> > kcalloc manages count*sizeof overflow.
> > 
> > Cc: Artem Bityutskiy <dedekind1@gmail.com>
> > Cc: Adrian Hunter <adrian.hunter@intel.com>
> > Cc: linux-mtd@lists.infradead.org
> > Signed-off-by: Fabian Frederick <fabf@skynet.be>
> 
> In the commit message, please, try to not only tell _what_ you do,
> but also _why_ you do this. And ideally, but not necessary for this
> case, I think, how this was tested (e.g., compile-tested only).

Oh, I'm sorry, you did tell "why" in this patch, I was looking an the a
different patch of yours (seq_printf). I've applied this patch to
linux-ubifs.git, thanks!

-- 
Best Regards,
Artem Bityutskiy