linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: hujianyang <hujianyang@huawei.com>
Cc: MTD Maling List <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH 2/2] UBIFS: add a log overlap assertion
Date: Mon, 28 Jul 2014 19:18:01 +0300	[thread overview]
Message-ID: <1406564281.23376.35.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <53CDBFDB.6080300@huawei.com>

On Tue, 2014-07-22 at 09:35 +0800, hujianyang wrote:
> I have to tell you this patch seems wrong. I've tested this patch
> and saw lots of 'assert_failed()'. We use ubifs_next_log_lnum()
> as an iterator to scan the hole log area and the return value of
> this function may equal to c->ltail_lnum.

OK, thanks. I've reverted my bogus patch.

Would you please re-send your patch with proper commit message, etc, so
that I could 'git am' it. This time I'd like to apply a patch which has
been tested. Thanks!

-- 
Best Regards,
Artem Bityutskiy

  reply	other threads:[~2014-07-28 16:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-16 12:42 [PATCH 1/2] UBIFS: fix free log space calculation Artem Bityutskiy
2014-07-16 12:42 ` [PATCH 2/2] UBIFS: add a log overlap assertion Artem Bityutskiy
2014-07-22  1:35   ` hujianyang
2014-07-28 16:18     ` Artem Bityutskiy [this message]
2014-07-29 10:27       ` hujianyang
2014-08-11  3:21 ` [PATCH 1/2] UBIFS: fix free log space calculation hujianyang
2014-09-08  9:43   ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1406564281.23376.35.camel@sauron.fi.intel.com \
    --to=dedekind1@gmail.com \
    --cc=hujianyang@huawei.com \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).