From: Artem Bityutskiy <dedekind1@gmail.com>
To: Zhang Zhen <zhenzhang.zhang@huawei.com>
Cc: wangnan0@huawei.com,
MTD Maling List <linux-mtd@lists.infradead.org>,
Adrian Hunter <adrian.hunter@intel.com>
Subject: Re: [PATCH v2] ubifs: refactor ubifs_file_mmap()
Date: Mon, 28 Jul 2014 19:25:13 +0300 [thread overview]
Message-ID: <1406564713.23376.39.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <53CE049B.7050801@huawei.com>
On Tue, 2014-07-22 at 14:28 +0800, Zhang Zhen wrote:
> generic_file_mmap() set vma->vm_ops = &generic_file_vm_ops,
> then ubifs_file_mmap set vma->vm_ops = &ubifs_file_vm_ops.
> So it is redundant.
> And there is no kind of file does not supply page reading function
> in ubifs. The readpage() check up for mmap file in generic_file_mmap()
> is not needed.
>
> So remove the call of generic_file_mmap().
>
> Change v1 -> v2:
> - deleted the mapping variable
> Signed-off-by: Zhang Zhen <zhenzhang.zhang@huawei.com>
Hi, I am not sure about this patch. 'generic_file_mmap()' covers !
CONFIG_MMU case too, for example.
Thanks!
--
Best Regards,
Artem Bityutskiy
next prev parent reply other threads:[~2014-07-28 16:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1406010548-13996-1-git-send-email-zhenzhang.zhang@huawei.com>
2014-07-22 6:28 ` [PATCH v2] ubifs: refactor ubifs_file_mmap() Zhang Zhen
2014-07-28 16:25 ` Artem Bityutskiy [this message]
2014-07-29 3:50 ` Zhang Zhen
2014-07-29 7:20 ` Artem Bityutskiy
2014-07-29 7:33 ` Zhang Zhen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406564713.23376.39.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=adrian.hunter@intel.com \
--cc=linux-mtd@lists.infradead.org \
--cc=wangnan0@huawei.com \
--cc=zhenzhang.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox