[PATCH v2] mtd: atmel_nand: NFC: fix mtd_nandbiterrs.ko test fail when using sram write

[PATCH v2] mtd: atmel_nand: NFC: fix mtd_nandbiterrs.ko test fail when using sram write

[Josh Wu]

When enable NFC sram write, it will failed the mtd_nandbiterrs.ko test.

As in driver's nfc_sram_write_page(), if ops->mode equal to MTD_OSP_RAW,
driver assumes the data buffer contains one page data and one oob data
followed. And driver will write the page data and oob data to nand.

But this is wrong implementation. Since the data buffer don't contains the
oob data to write. We should write the chip->oob_poi to nand's oob.

So this patch fix it by writing the oob data from chip->oob_poi.

Signed-off-by: Josh Wu <josh.wu@atmel.com>
---
v1 -> v2:
  drop the sanity check for if write_page will write more than 1 page. As
NAND layer will guarantees that.

 drivers/mtd/nand/atmel_nand.c | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
index fa3fb47..003f661 100644
--- a/drivers/mtd/nand/atmel_nand.c
+++ b/drivers/mtd/nand/atmel_nand.c
@@ -1907,15 +1907,7 @@ static int nfc_sram_write_page(struct mtd_info *mtd, struct nand_chip *chip,
 	if (offset || (data_len < mtd->writesize))
 		return -EINVAL;
 
-	cfg = nfc_readl(host->nfc->hsmc_regs, CFG);
 	len = mtd->writesize;
-
-	if (unlikely(raw)) {
-		len += mtd->oobsize;
-		nfc_writel(host->nfc->hsmc_regs, CFG, cfg | NFC_CFG_WSPARE);
-	} else
-		nfc_writel(host->nfc->hsmc_regs, CFG, cfg & ~NFC_CFG_WSPARE);
-
 	/* Copy page data to sram that will write to nand via NFC */
 	if (use_dma) {
 		if (atmel_nand_dma_op(mtd, (void *)buf, len, 0) != 0)
@@ -1925,6 +1917,15 @@ static int nfc_sram_write_page(struct mtd_info *mtd, struct nand_chip *chip,
 		memcpy32_toio(sram, buf, len);
 	}
 
+	cfg = nfc_readl(host->nfc->hsmc_regs, CFG);
+	if (unlikely(raw) && oob_required) {
+		memcpy32_toio(sram + len, chip->oob_poi, mtd->oobsize);
+		len += mtd->oobsize;
+		nfc_writel(host->nfc->hsmc_regs, CFG, cfg | NFC_CFG_WSPARE);
+	} else {
+		nfc_writel(host->nfc->hsmc_regs, CFG, cfg & ~NFC_CFG_WSPARE);
+	}
+
 	if (chip->ecc.mode == NAND_ECC_HW && host->has_pmecc)
 		/*
 		 * When use NFC sram, need set up PMECC before send
-- 
1.9.1

Re: [PATCH v2] mtd: atmel_nand: NFC: fix mtd_nandbiterrs.ko test fail when using sram write

[Brian Norris]

On Tue, Aug 05, 2014 at 06:38:52PM +0800, Josh Wu wrote:
> When enable NFC sram write, it will failed the mtd_nandbiterrs.ko test.
> 
> As in driver's nfc_sram_write_page(), if ops->mode equal to MTD_OSP_RAW,
> driver assumes the data buffer contains one page data and one oob data
> followed. And driver will write the page data and oob data to nand.
> 
> But this is wrong implementation. Since the data buffer don't contains the
> oob data to write. We should write the chip->oob_poi to nand's oob.
> 
> So this patch fix it by writing the oob data from chip->oob_poi.
> 
> Signed-off-by: Josh Wu <josh.wu@atmel.com>
> ---
> v1 -> v2:
>   drop the sanity check for if write_page will write more than 1 page. As
> NAND layer will guarantees that.

Queued to l2-mtd.git/next. Thanks!

Brian