From: Artem Bityutskiy <dedekind1@gmail.com>
To: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Cc: Colin King <colin.king@canonical.com>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH][V2] UBI: block: fix dereference on uninitialized dev
Date: Mon, 08 Sep 2014 13:26:49 +0300 [thread overview]
Message-ID: <1410172009.10764.135.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <20140821191246.GA13322@arch.cereza>
On Thu, 2014-08-21 at 16:12 -0300, Ezequiel Garcia wrote:
> On 20 Aug 10:19 AM, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > commit 4df38926f337 ("UBI: block: Avoid disk size integer overflow")
> > introduced a dereference on dev (which is not initialized at that
> > point) when printing a warning message. Re-order disk_capacity check
> > after the dev is found.
> >
> > Found by cppcheck:
> > [drivers/mtd/ubi/block.c:509]: (error) Uninitialized variable: dev
> >
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> Acked-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Do we want to have this patch in @stable?
--
Best Regards,
Artem Bityutskiy
next prev parent reply other threads:[~2014-09-08 10:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-20 9:19 [PATCH][V2] UBI: block: fix dereference on uninitialized dev Colin King
2014-08-21 19:12 ` Ezequiel Garcia
2014-09-08 10:26 ` Artem Bityutskiy [this message]
2014-09-08 12:56 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410172009.10764.135.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=colin.king@canonical.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=ezequiel.garcia@free-electrons.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox