From: Artem Bityutskiy <dedekind1@gmail.com>
To: David Binderman <dcb314@hotmail.com>
Cc: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>
Subject: Re: mtd-utils-1.5.1 bug report
Date: Mon, 08 Sep 2014 14:50:01 +0300 [thread overview]
Message-ID: <1410177001.10764.158.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <DUB128-W61F274D19C6B54433EDD629CC00@phx.gbl>
On Sun, 2014-09-07 at 14:58 +0000, David Binderman wrote:
> Hello there,
>
> ubi-utils/ubiformat.c:636:28: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]
>
> if (!args.subpage_size != mtd->min_io_size)
> normsg("may be sub-page size is "
> "incorrect?");
>
> Something boolean compared to a size. Looks a possible problem to me.
> Removal of the double negative might also help.
Care to send a patch?
--
Best Regards,
Artem Bityutskiy
next prev parent reply other threads:[~2014-09-08 11:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-07 14:58 mtd-utils-1.5.1 bug report David Binderman
2014-09-08 11:50 ` Artem Bityutskiy [this message]
2014-09-08 12:09 ` Artem Bityutskiy
2014-09-16 15:13 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410177001.10764.158.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=dcb314@hotmail.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox