From: Artem Bityutskiy <dedekind1@gmail.com>
To: David Binderman <dcb314@hotmail.com>
Cc: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>
Subject: Re: mtd-utils-1.5.1 bug report
Date: Tue, 16 Sep 2014 18:13:36 +0300 [thread overview]
Message-ID: <1410880416.28850.47.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <1410178188.10764.159.camel@sauron.fi.intel.com>
On Mon, 2014-09-08 at 15:09 +0300, Artem Bityutskiy wrote:
> On Sun, 2014-09-07 at 14:58 +0000, David Binderman wrote:
> > Hello there,
> >
> > ubi-utils/ubiformat.c:636:28: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]
> >
> > if (!args.subpage_size != mtd->min_io_size)
> > normsg("may be sub-page size is "
> > "incorrect?");
>
> Hi,
>
> I'd propose this patch to fix the issue:
>
> Subject: [PATCH] ubiformat: fix the subpage size hint on the error path
I've just pushed this patch to mtd-utils.git. I did not test it, but
hopefully it is trivial enough and not so risky since it changes the
error path.
--
Best Regards,
Artem Bityutskiy
prev parent reply other threads:[~2014-09-16 15:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-07 14:58 mtd-utils-1.5.1 bug report David Binderman
2014-09-08 11:50 ` Artem Bityutskiy
2014-09-08 12:09 ` Artem Bityutskiy
2014-09-16 15:13 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410880416.28850.47.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=dcb314@hotmail.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox