From: Artem Bityutskiy <dedekind1@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-mtd@lists.infradead.org, kernel-janitors@vger.kernel.org,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [patch] UBI: return on error in rename_volumes()
Date: Fri, 19 Sep 2014 18:15:21 +0300 [thread overview]
Message-ID: <1411139721.28850.143.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <20140919104848.GC26391@mwanda>
On Fri, 2014-09-19 at 13:56 +0300, Dan Carpenter wrote:
> I noticed this during a code review. We are checking that the strlen()
> of ->name is not less than the ->name_len which the user gave us. I
> believe this bug is harmless but clearly we meant to return here instead
> of setting an error code and then not using it.
Pushed to linux-ubifs.git, thanks!
--
Best Regards,
Artem Bityutskiy
prev parent reply other threads:[~2014-09-19 15:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-19 10:56 [patch] UBI: return on error in rename_volumes() Dan Carpenter
2014-09-19 15:15 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1411139721.28850.143.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=computersforpeace@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=dwmw2@infradead.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox