Re: [PATCH v4] mtd: ubi: Extend UBI layer debug/messaging capabilities

Ezequiel Garcia
2014-10-14T18:49:01Z

On 14 Oct 06:09 PM, Artem Bityutskiy wrote:
> On Tue, 2014-10-14 at 11:39 -0300, Ezequiel Garcia wrote:
> > Please use some pr_fmt for this. Something like this before the headers
> > should be enough:
> >
> > #define pr_fmt(fmt) "UBI: block:" fmt
>
> Sinc ubiblock is a device, there should be a 'struct device' somewhere,
> so probably dev_printk() and other dev_*() printing functions would be a
> better choice?
>

A quick code dig shows you should get the struct device associated
to the struct gendisk, with the disk_to_dev() macro.

In other words, something like this should work, provided 'dev' is defined
in the scope as a struct ubiblock:

#define ubiblock_err(x) dev_err(disk_to_dev(dev->gd), x)

When the gendisk is not available, a simple pr_{} would work.
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering