From: Artem Bityutskiy <dedekind1@gmail.com>
To: hujianyang <hujianyang@huawei.com>
Cc: Richard Weinberger <richard.weinberger@gmail.com>,
linux-mtd <linux-mtd@lists.infradead.org>,
Bill Pringlemeir <bpringlemeir@nbsps.com>
Subject: Re: [PATCH v5 3/4] ubi-utils: ubidump: introduce ubidump
Date: Fri, 31 Oct 2014 09:32:02 +0200 [thread overview]
Message-ID: <1414740722.23185.63.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <5452F133.2030701@huawei.com>
On Fri, 2014-10-31 at 10:17 +0800, hujianyang wrote:
> >
> > And "-i" / "--info" are not the best names, I think. "-u" / "--ubifs"
> > would be better.
> >
>
> Oh, I'd like to reserve this "--ubifs" when we are ready to dump ubi-level
> stuff. So in my previous design, "--ubifs" and "--ubi" are used to indicate
> only dump the specific area of an eraseblock.
>
> How about an option like "--node" ? Do you insist on "--ubifs" or have
> another suggestion?
The idea is that you introduce an option, and then you do not change
it's name. So the name should be informative. What is more informative
for "also dump ubifs nodes": --node or --ubifs ?
You can always add --ubi later.
For now, if --ubifs is not specified, you should do basically nothing,
because you cannot dump UBI right now.
Does this make sense for you?
Artem.
next prev parent reply other threads:[~2014-10-31 7:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-22 10:37 [PATCH v5 1/4] ubi-utils: ubidump: add ubifs-media hujianyang
2014-10-22 10:40 ` [PATCH v5 2/4] ubi-utils: ubidump: add libdump hujianyang
2014-10-22 10:43 ` [PATCH v5 3/4] ubi-utils: ubidump: introduce ubidump hujianyang
2014-10-30 8:19 ` Artem Bityutskiy
2014-10-30 8:30 ` Artem Bityutskiy
2014-10-31 2:17 ` hujianyang
2014-10-31 7:32 ` Artem Bityutskiy [this message]
2014-10-31 10:55 ` hujianyang
2014-10-31 13:20 ` Artem Bityutskiy
2014-11-20 9:24 ` hujianyang
2014-11-27 14:32 ` Artem Bityutskiy
2014-12-01 1:45 ` hujianyang
2014-10-22 10:47 ` [PATCH v5 4/4] ubi-utils: ubidump: compile enable hujianyang
2014-10-30 7:51 ` [PATCH v5 1/4] ubi-utils: ubidump: add ubifs-media Artem Bityutskiy
2014-10-30 8:01 ` Artem Bityutskiy
2014-10-31 2:03 ` hujianyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414740722.23185.63.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=bpringlemeir@nbsps.com \
--cc=hujianyang@huawei.com \
--cc=linux-mtd@lists.infradead.org \
--cc=richard.weinberger@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).