From: Artem Bityutskiy <dedekind1@gmail.com>
To: Richard Weinberger <richard@nod.at>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
tlinder@codeaurora.org
Subject: Re: [PATCH 08/35] UBI: Split __wl_get_peb()
Date: Thu, 06 Nov 2014 09:51:46 +0200 [thread overview]
Message-ID: <1415260306.958.158.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <1414586758-9972-9-git-send-email-richard@nod.at>
On Wed, 2014-10-29 at 13:45 +0100, Richard Weinberger wrote:
> Make it two functions, wl_get_wle() and wl_get_peb().
> wl_get_peb() works exactly like __wl_get_peb() but wl_get_wle()
> does not call produce_free_peb().
> While refilling the fastmap user pool we cannot release ubi->wl_lock
> as produce_free_peb() does.
> Hence the fastmap logic uses now wl_get_wle().
>
> Signed-off-by: Richard Weinberger <richard@nod.at>
Please, re-consider naming.
The convention is that non-static function names start with ubi_wl_*.
Static function names start with _*.
Also, please add a comment above the functions explaining what it does.
Artem.
next prev parent reply other threads:[~2014-11-06 7:52 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-29 12:45 UBI Fastmap stabilization Richard Weinberger
2014-10-29 12:45 ` [PATCH 01/35] UBI: Add initial support for fastmap self checks Richard Weinberger
2014-12-04 10:52 ` Tanya Brokhman
2014-10-29 12:45 ` [PATCH 02/35] UBI: Fix stale pointers in ubi->lookuptbl Richard Weinberger
2014-11-05 15:14 ` Artem Bityutskiy
2014-12-04 11:00 ` Tanya Brokhman
2014-12-04 11:04 ` Richard Weinberger
2014-12-04 12:37 ` Tanya Brokhman
2014-12-04 12:40 ` Richard Weinberger
2014-10-29 12:45 ` [PATCH 03/35] UBI: Fastmap: Add self check to detect absent PEBs Richard Weinberger
2014-11-05 15:23 ` Artem Bityutskiy
2014-11-05 15:56 ` Richard Weinberger
2014-11-05 16:01 ` Artem Bityutskiy
2014-11-05 16:05 ` Richard Weinberger
2014-11-06 7:55 ` Artem Bityutskiy
2014-10-29 12:45 ` [PATCH 04/35] UBI: Fastmap: Care about the protection queue Richard Weinberger
2014-10-29 12:45 ` [PATCH 05/35] UBI: Fastmap: Ensure that only one fastmap work is scheduled Richard Weinberger
2014-11-05 15:42 ` Artem Bityutskiy
2014-11-05 15:47 ` Richard Weinberger
2014-10-29 12:45 ` [PATCH 06/35] UBI: Fastmap: Ensure that all fastmap work is done upon WL shutdown Richard Weinberger
2014-11-05 15:45 ` Artem Bityutskiy
2014-11-05 15:49 ` Richard Weinberger
2014-11-05 15:54 ` Artem Bityutskiy
2014-11-05 15:59 ` Richard Weinberger
2014-11-05 16:05 ` Artem Bityutskiy
2014-10-29 12:45 ` [PATCH 07/35] UBI: Fastmap: Fix races in ubi_wl_get_peb() Richard Weinberger
2014-11-05 15:51 ` Artem Bityutskiy
2014-10-29 12:45 ` [PATCH 08/35] UBI: Split __wl_get_peb() Richard Weinberger
2014-11-06 7:51 ` Artem Bityutskiy [this message]
2014-11-06 7:55 ` Richard Weinberger
2014-10-29 12:45 ` [PATCH 09/35] UBI: Fastmap: Make ubi_refill_pools() fair Richard Weinberger
2014-10-29 12:45 ` [PATCH 10/35] UBI: Fastmap: Fix memory leaks while closing the WL sub-system Richard Weinberger
2014-10-29 12:45 ` [PATCH 11/35] UBI: Fastmap: Don't allocate new ubi_wl_entry objects Richard Weinberger
2014-10-29 12:45 ` [PATCH 12/35] UBI: Fastmap: Notify user in case of an ubi_update_fastmap() failure Richard Weinberger
2014-10-29 12:45 ` [PATCH 13/35] UBI: Fastmap: Wrap fastmap specific function in a ifdef Richard Weinberger
2014-10-29 12:45 ` [PATCH 14/35] UBI: Fastmap: Fix fastmap usage in ubi_volume_notify() Richard Weinberger
2014-10-29 12:45 ` [PATCH 15/35] UBI: Fastmap: Enhance fastmap checking Richard Weinberger
2014-10-29 12:45 ` [PATCH 16/35] UBI: Fastmap: Fix memory leak while attaching Richard Weinberger
2014-10-29 12:45 ` [PATCH 17/35] UBI: Remove alloc_ai() slab name from parameter list Richard Weinberger
2014-10-29 12:45 ` [PATCH 18/35] UBI: Fastmap: Fix race in ubi_eba_atomic_leb_change() Richard Weinberger
2014-10-29 12:45 ` [PATCH 19/35] UBI: Fastmap: Remove bogus ubi_assert() Richard Weinberger
2014-10-29 12:45 ` [PATCH 20/35] UBI: Fastmap: Remove eba_orphans logic Richard Weinberger
2014-10-29 12:45 ` [PATCH 21/35] UBI: Fastmap: Switch to ro mode if invalidate_fastmap() fails Richard Weinberger
2014-10-29 12:45 ` [PATCH 22/35] UBI: Fastmap: Make WL pool size 50% of user pool size Richard Weinberger
2014-10-29 12:45 ` [PATCH 23/35] UBI: Fastmap: Add new module parameter fm_debug Richard Weinberger
2014-10-29 12:45 ` [PATCH 24/35] UBI: Fastmap: Fix leb_count unbalance Richard Weinberger
2014-10-29 12:45 ` [PATCH 25/35] UBI: Fastmap: Fix race after ubi_wl_get_peb() Richard Weinberger
2014-10-29 12:45 ` [PATCH 26/35] UBI: Fastmap: Set used_ebs only for static volumes Richard Weinberger
2014-10-29 12:45 ` [PATCH 27/35] UBI: Fastmap: Locking updates Richard Weinberger
2014-10-29 12:45 ` [PATCH 28/35] UBI: Fastmap: Make self_check_eba() depend on fastmap self checking Richard Weinberger
2014-10-29 12:45 ` [PATCH 29/35] UBI: Move fastmap specific functions out of wl.c Richard Weinberger
2014-10-29 12:45 ` [PATCH 30/35] UBI: Add accessor functions for WL data structures Richard Weinberger
2014-10-29 12:45 ` [PATCH 31/35] UBI: Fastmap: Wire up WL accessor functions Richard Weinberger
2014-10-29 12:45 ` [PATCH 32/35] UBI: Fastmap: Introduce ubi_fastmap_init() Richard Weinberger
2014-10-29 12:45 ` [PATCH 33/35] UBI: Fastmap: Introduce may_reserve_for_fm() Richard Weinberger
2014-10-29 12:45 ` [PATCH 34/35] UBI: Fastmap: Remove else after return Richard Weinberger
2014-10-29 12:45 ` [PATCH 35/35] UBI: Fastmap: Add blank line after declarations Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415260306.958.158.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=tlinder@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).