From: Artem Bityutskiy <dedekind1@gmail.com>
To: Ben Shelton <ben.shelton@ni.com>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>,
Subodh Nijsure <snijsure@grid-net.com>,
linux-mtd@lists.infradead.org, adrian.hunter@intel.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] UBIFS: Add xattr support for symlinks
Date: Tue, 11 Nov 2014 13:04:29 +0200 [thread overview]
Message-ID: <1415703869.22887.132.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <1414781431-2911-3-git-send-email-ben.shelton@ni.com>
I've pushed this patch to the master branch. But I did ab amendment.
On Fri, 2014-10-31 at 13:50 -0500, Ben Shelton wrote:
> +static int __ubifs_setxattr(struct inode *host, const char *name,
> + const void *value, size_t size, int flags)
> {
I renamed this to just 'setxattr()', to be consistent wit the rest of
the code where we use the following convention:
* non-static functions start with 'ubifs_'
* static functions use any name, and do not start with 'ubifs_'
* we just do not prefix functions with '__' anywhere, so let's not use
it in xattr.c either.
Artem.
next prev parent reply other threads:[~2014-11-11 11:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-31 18:50 [PATCH 0/4] UBIFS: add xattr support for security / SELinux Ben Shelton
2014-10-31 18:50 ` [PATCH 1/4] UBIFS: fix a couple bugs in UBIFS xattr length calculation Ben Shelton
2014-11-07 10:34 ` Artem Bityutskiy
2014-11-07 19:56 ` Ben Shelton
2014-10-31 18:50 ` [PATCH 2/4] UBIFS: Add xattr support for symlinks Ben Shelton
2014-11-10 14:01 ` Artem Bityutskiy
2014-11-10 17:12 ` Ben Shelton
2014-11-11 10:17 ` Artem Bityutskiy
2014-11-11 11:04 ` Artem Bityutskiy [this message]
2014-10-31 18:50 ` [PATCH 3/4] UBIFS: Add security.* XATTR support for the UBIFS Ben Shelton
2014-11-11 11:07 ` Artem Bityutskiy
2014-10-31 18:50 ` [PATCH 4/4] UBIFS: add ubifs_err() to print error reason Ben Shelton
2014-11-11 11:10 ` Artem Bityutskiy
2014-11-11 16:08 ` Ben Shelton
2014-11-12 12:31 ` Artem Bityutskiy
2014-11-07 9:53 ` [PATCH 0/4] UBIFS: add xattr support for security / SELinux Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415703869.22887.132.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=adrian.hunter@intel.com \
--cc=ben.shelton@ni.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mkl@pengutronix.de \
--cc=snijsure@grid-net.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox