From: <chenjie6@huawei.com>
To: <linux-mtd@lists.infradead.org>, <David.Woodhouse@intel.com>
Cc: computersforpeace@gmail.com, akpm@linux-foundation.org,
lizefan@huawei.com, zengweilin@huawei.com
Subject: [PATCH] [RESEND] jffs2: bugfix of summary length
Date: Fri, 12 Dec 2014 03:03:44 +0800 [thread overview]
Message-ID: <1418324624-29697-1-git-send-email-chenjie6@huawei.com> (raw)
From: chenjie <chenjie6@huawei.com>
When power is off, the magic of summary is writed but the length not
so the length is 0xffffffff, sumlen maybe very large.
The kmalloc() failed and mount failed.
Cc: <stable@vger.kernel.org>
Signed-off-by: Chen Jie <chenjie6@huawei.com>
---
fs/jffs2/scan.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/fs/jffs2/scan.c b/fs/jffs2/scan.c
index 7654e87..6187e56 100644
--- a/fs/jffs2/scan.c
+++ b/fs/jffs2/scan.c
@@ -510,6 +510,9 @@ static int jffs2_scan_eraseblock (struct jffs2_sb_info *c, struct jffs2_eraseblo
sumlen = c->sector_size - je32_to_cpu(sm->offset);
sumptr = buf + buf_size - sumlen;
+ if (sumlen > c->sector_size)
+ goto full_scan;
+
/* Now, make sure the summary itself is available */
if (sumlen > buf_size) {
/* Need to kmalloc for this. */
@@ -544,6 +547,7 @@ static int jffs2_scan_eraseblock (struct jffs2_sb_info *c, struct jffs2_eraseblo
}
}
+full_scan:
buf_ofs = jeb->offset;
if (!buf_size) {
--
1.8.0
next reply other threads:[~2014-12-11 11:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-11 19:03 chenjie6 [this message]
2014-12-13 3:20 ` [PATCH] [RESEND] jffs2: bugfix of summary length Brian Norris
-- strict thread matches above, loose matches on Subject: below --
2014-12-18 11:04 chenjie6
2014-12-18 21:50 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418324624-29697-1-git-send-email-chenjie6@huawei.com \
--to=chenjie6@huawei.com \
--cc=David.Woodhouse@intel.com \
--cc=akpm@linux-foundation.org \
--cc=computersforpeace@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=lizefan@huawei.com \
--cc=zengweilin@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox