Linux-mtd Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: chengzhihao1 <chengzhihao1@huawei.com>
Cc: linux-mtd <linux-mtd@lists.infradead.org>,
	 linux-kernel <linux-kernel@vger.kernel.org>,
	 Ben Hutchings <bwh@kernel.org>,
	kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] ubi: Fix ubi_init() ubiblock_exit() section mismatch
Date: Sat, 13 Jul 2024 10:46:30 +0200 (CEST)	[thread overview]
Message-ID: <1422580650.65606.1720860390692.JavaMail.zimbra@nod.at> (raw)
In-Reply-To: <3c624cf1-b5a3-f89c-ac6a-0875fcabaf25@huawei.com>

----- Ursprüngliche Mail -----
> Von: "chengzhihao1" <chengzhihao1@huawei.com>
> An: "richard" <richard@nod.at>, "linux-mtd" <linux-mtd@lists.infradead.org>
> CC: "linux-kernel" <linux-kernel@vger.kernel.org>, "Ben Hutchings" <bwh@kernel.org>, "kernel test robot" <lkp@intel.com>
> Gesendet: Samstag, 13. Juli 2024 10:16:15
> Betreff: Re: [PATCH] ubi: Fix ubi_init() ubiblock_exit() section mismatch

> 在 2024/7/13 15:35, Richard Weinberger 写道:
>> Since ubiblock_exit() is now called from an init function,
>> the __exit section no longer makes sense.
>> 
>> Cc: Ben Hutchings <bwh@kernel.org>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Closes:
>> https://lore.kernel.org/oe-kbuild-all/202407131403.wZJpd8n2-lkp@intel.com/
>> Signed-off-by: Richard Weinberger <richard@nod.at>
>> ---
>>   drivers/mtd/ubi/block.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Looks like that you prefer a simpler fix. Feel fine to add

Yes, and Ben sent the patch first. :)
 
> Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com>

Thanks for the review!
And especially thanks for reviewing so many UBI/UBIFS patches,
I appreciate your help.

Thanks,
//richard


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2024-07-13  8:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-13  7:35 [PATCH] ubi: Fix ubi_init() ubiblock_exit() section mismatch Richard Weinberger
2024-07-13  8:16 ` Zhihao Cheng
2024-07-13  8:46   ` Richard Weinberger [this message]
2024-07-13  9:02     ` Zhihao Cheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1422580650.65606.1720860390692.JavaMail.zimbra@nod.at \
    --to=richard@nod.at \
    --cc=bwh@kernel.org \
    --cc=chengzhihao1@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=lkp@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox