* [PATCH] mtd: nand: gpmi: Check for scan_bbt() error
@ 2015-02-09 21:22 Fabio Estevam
2015-02-10 3:29 ` Huang Shijie
2015-03-31 1:28 ` Brian Norris
0 siblings, 2 replies; 3+ messages in thread
From: Fabio Estevam @ 2015-02-09 21:22 UTC (permalink / raw)
To: computersforpeace; +Cc: Fabio Estevam, linux-mtd, shijie8
From: Fabio Estevam <fabio.estevam@freescale.com>
In case of scan_bbt() failure, we should better propagate it.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
index 33f3c3c..8ce8bb2 100644
--- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
+++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
@@ -1950,7 +1950,9 @@ static int gpmi_nand_init(struct gpmi_nand_data *this)
ret = nand_boot_init(this);
if (ret)
goto err_out;
- chip->scan_bbt(mtd);
+ ret = chip->scan_bbt(mtd);
+ if (ret)
+ goto err_out;
ppdata.of_node = this->pdev->dev.of_node;
ret = mtd_device_parse_register(mtd, NULL, &ppdata, NULL, 0);
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: nand: gpmi: Check for scan_bbt() error
2015-02-09 21:22 [PATCH] mtd: nand: gpmi: Check for scan_bbt() error Fabio Estevam
@ 2015-02-10 3:29 ` Huang Shijie
2015-03-31 1:28 ` Brian Norris
1 sibling, 0 replies; 3+ messages in thread
From: Huang Shijie @ 2015-02-10 3:29 UTC (permalink / raw)
To: Fabio Estevam; +Cc: Fabio Estevam, shijie8, computersforpeace, linux-mtd
On Mon, Feb 09, 2015 at 07:22:33PM -0200, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> In case of scan_bbt() failure, we should better propagate it.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
thanks
Acked-by: Huang Shijie <shijie.huang@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: nand: gpmi: Check for scan_bbt() error
2015-02-09 21:22 [PATCH] mtd: nand: gpmi: Check for scan_bbt() error Fabio Estevam
2015-02-10 3:29 ` Huang Shijie
@ 2015-03-31 1:28 ` Brian Norris
1 sibling, 0 replies; 3+ messages in thread
From: Brian Norris @ 2015-03-31 1:28 UTC (permalink / raw)
To: Fabio Estevam; +Cc: Fabio Estevam, linux-mtd, shijie8
On Mon, Feb 09, 2015 at 07:22:33PM -0200, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> In case of scan_bbt() failure, we should better propagate it.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Pushed to l2-mtd.git. Thanks!
Brian
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-31 1:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-09 21:22 [PATCH] mtd: nand: gpmi: Check for scan_bbt() error Fabio Estevam
2015-02-10 3:29 ` Huang Shijie
2015-03-31 1:28 ` Brian Norris
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox