From: Brian Norris <computersforpeace@gmail.com>
To: Richard Weinberger <richard@nod.at>,
Artem Bityutskiy <dedekind1@gmail.com>
Cc: kernel-janitors@vger.kernel.org,
Brian Norris <computersforpeace@gmail.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/5] UBI: account for bitflips in both the VID header and data
Date: Sat, 28 Feb 2015 02:23:25 -0800 [thread overview]
Message-ID: <1425119009-28634-2-git-send-email-computersforpeace@gmail.com> (raw)
In-Reply-To: <1425119009-28634-1-git-send-email-computersforpeace@gmail.com>
We are completely discarding the earlier value of 'bitflips', which
could reflect a bitflip found in ubi_io_read_vid_hdr(). Let's use the
bitwise OR of header and data 'bitflip' statuses instead.
Coverity CID #1226856
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
---
drivers/mtd/ubi/attach.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/ubi/attach.c b/drivers/mtd/ubi/attach.c
index 9d2e16f3150a..b5e154856994 100644
--- a/drivers/mtd/ubi/attach.c
+++ b/drivers/mtd/ubi/attach.c
@@ -410,7 +410,7 @@ int ubi_compare_lebs(struct ubi_device *ubi, const struct ubi_ainf_peb *aeb,
second_is_newer = !second_is_newer;
} else {
dbg_bld("PEB %d CRC is OK", pnum);
- bitflips = !!err;
+ bitflips |= !!err;
}
mutex_unlock(&ubi->buf_mutex);
--
2.1.0
next prev parent reply other threads:[~2015-02-28 10:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-28 10:23 [PATCH 0/5] UBI: Coverity-inspired fixes Brian Norris
2015-02-28 10:23 ` Brian Norris [this message]
2015-02-28 10:23 ` [PATCH 2/5] UBI: fix out of bounds write Brian Norris
2015-02-28 10:23 ` [PATCH 3/5] UBI: initialize LEB number variable Brian Norris
2015-02-28 10:23 ` [PATCH 4/5] UBI: fix check for "too many bytes" Brian Norris
2015-03-26 9:29 ` Richard Weinberger
2015-02-28 10:23 ` [PATCH 5/5] UBI: align comment for readability Brian Norris
2015-03-05 10:33 ` [PATCH 0/5] UBI: Coverity-inspired fixes Richard Weinberger
2015-03-06 2:04 ` Brian Norris
2015-03-26 9:11 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425119009-28634-2-git-send-email-computersforpeace@gmail.com \
--to=computersforpeace@gmail.com \
--cc=dedekind1@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).