linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: rnd4@dave-tech.it
To: linux-mtd@lists.infradead.org
Cc: boris.brezillon@free-electrons.com, Andrea Scian <andrea.scian@dave.eu>
Subject: [PATCH 1/2] mtd: nand: use a lower value for badblockbits when working with MLC NAND
Date: Fri,  6 Mar 2015 13:12:17 +0100	[thread overview]
Message-ID: <1425643938-24749-2-git-send-email-rnd4@dave-tech.it> (raw)
In-Reply-To: <1425643938-24749-1-git-send-email-rnd4@dave-tech.it>

From: Andrea Scian <andrea.scian@dave.eu>

MLC NANDs have more bit flips that SLC. When looking for bad block
marker we have a lot of false positive if we check for the whole byte. To
avoid this tolerate a few (4 here) bit flips for byte.

Signed-off-by: Andrea Scian <andrea.scian@dave.eu>
---
 drivers/mtd/nand/nand_base.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
index dfcd0a5..bdca223 100644
--- a/drivers/mtd/nand/nand_base.c
+++ b/drivers/mtd/nand/nand_base.c
@@ -3315,7 +3315,10 @@ ident_done:
 		chip->chip_shift += 32 - 1;
 	}
 
-	chip->badblockbits = 8;
+	if (nand_is_slc(chip))
+		chip->badblockbits = 8;
+	else
+		chip->badblockbits = 4;
 	chip->erase_cmd = single_erase_cmd;
 
 	/* Do not replace user supplied command function! */
-- 
1.7.9.5

  reply	other threads:[~2015-03-06 12:12 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-06 12:12 [PATCH 0/2] Use badblockbits-like approach in nand_bbt.c rnd4
2015-03-06 12:12 ` rnd4 [this message]
2015-03-15  9:07   ` [PATCH 1/2] mtd: nand: use a lower value for badblockbits when working with MLC NAND Boris Brezillon
2015-04-03 12:52     ` Andrea Scian
2015-07-23 21:24       ` Andrea Scian
2015-07-23 22:00         ` Brian Norris
2015-03-06 12:12 ` [PATCH 2/2] mtd: nand: use nand_chip badblockbits when checking bad block pattern rnd4
2015-03-15  9:18   ` Boris Brezillon
2015-10-13 10:46 ` [PATCH 0/2] Use badblockbits-like approach in nand_bbt.c Boris Brezillon
2015-10-13 18:04   ` Brian Norris
     [not found] <A765B125120D1346A63912DDE6D8B6310BF69672@NTXXIAMBX02.xacn.micron.com>
2016-03-09 14:26 ` [PATCH 1/2] mtd: nand: use a lower value for badblockbits when working with MLC NAND Boris Brezillon
2016-03-09 16:37   ` Andrea Scian
2016-03-10  2:48     ` Bean Huo 霍斌斌 (beanhuo)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1425643938-24749-2-git-send-email-rnd4@dave-tech.it \
    --to=rnd4@dave-tech.it \
    --cc=andrea.scian@dave.eu \
    --cc=boris.brezillon@free-electrons.com \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).