* [PATCH] mtd: docg3: remove invalid __exit annotations
@ 2015-03-31 16:53 Brian Norris
2015-03-31 19:53 ` Robert Jarzmik
2015-04-06 1:07 ` Brian Norris
0 siblings, 2 replies; 3+ messages in thread
From: Brian Norris @ 2015-03-31 16:53 UTC (permalink / raw)
To: linux-mtd; +Cc: Brian Norris, Robert Jarzmik
The .remove callback may be used when detaching a device via sysfs, so
we can't expect to free up this memory.
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Cc: Robert Jarzmik <robert.jarzmik@free.fr>
---
Compile tested only
drivers/mtd/devices/docg3.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/mtd/devices/docg3.c b/drivers/mtd/devices/docg3.c
index 448ce42f951e..30b5be4e2109 100644
--- a/drivers/mtd/devices/docg3.c
+++ b/drivers/mtd/devices/docg3.c
@@ -1805,7 +1805,7 @@ static int __init doc_dbg_register(struct docg3 *docg3)
}
}
-static void __exit doc_dbg_unregister(struct docg3 *docg3)
+static void doc_dbg_unregister(struct docg3 *docg3)
{
debugfs_remove_recursive(docg3->debugfs_root);
}
@@ -2103,7 +2103,7 @@ err_probe:
*
* Returns 0
*/
-static int __exit docg3_release(struct platform_device *pdev)
+static int docg3_release(struct platform_device *pdev)
{
struct docg3_cascade *cascade = platform_get_drvdata(pdev);
struct docg3 *docg3 = cascade->floors[0]->priv;
@@ -2134,7 +2134,7 @@ static struct platform_driver g3_driver = {
},
.suspend = docg3_suspend,
.resume = docg3_resume,
- .remove = __exit_p(docg3_release),
+ .remove = docg3_release,
};
module_platform_driver_probe(g3_driver, docg3_probe);
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: docg3: remove invalid __exit annotations
2015-03-31 16:53 [PATCH] mtd: docg3: remove invalid __exit annotations Brian Norris
@ 2015-03-31 19:53 ` Robert Jarzmik
2015-04-06 1:07 ` Brian Norris
1 sibling, 0 replies; 3+ messages in thread
From: Robert Jarzmik @ 2015-03-31 19:53 UTC (permalink / raw)
To: Brian Norris; +Cc: linux-mtd
Brian Norris <computersforpeace@gmail.com> writes:
> The .remove callback may be used when detaching a device via sysfs, so
> we can't expect to free up this memory.
>
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> Cc: Robert Jarzmik <robert.jarzmik@free.fr>
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
Cheers.
--
Robert
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: docg3: remove invalid __exit annotations
2015-03-31 16:53 [PATCH] mtd: docg3: remove invalid __exit annotations Brian Norris
2015-03-31 19:53 ` Robert Jarzmik
@ 2015-04-06 1:07 ` Brian Norris
1 sibling, 0 replies; 3+ messages in thread
From: Brian Norris @ 2015-04-06 1:07 UTC (permalink / raw)
To: linux-mtd; +Cc: Robert Jarzmik
On Tue, Mar 31, 2015 at 09:53:37AM -0700, Brian Norris wrote:
> The .remove callback may be used when detaching a device via sysfs, so
> we can't expect to free up this memory.
>
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> Cc: Robert Jarzmik <robert.jarzmik@free.fr>
Pushed to l2-mtd.git.
Brian
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-04-06 1:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-31 16:53 [PATCH] mtd: docg3: remove invalid __exit annotations Brian Norris
2015-03-31 19:53 ` Robert Jarzmik
2015-04-06 1:07 ` Brian Norris
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox