From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lb3-smtp-cloud3.xs4all.net ([194.109.24.30]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YhjY9-0007QQ-PT for linux-mtd@lists.infradead.org; Mon, 13 Apr 2015 18:57:38 +0000 Message-ID: <1428951432.3868.21.camel@x220> Subject: Re: [PATCH v6 1/3] nand: pl353: Add basic driver for arm pl353 smc nand interface From: Paul Bolle To: Punnaiah Choudary Kalluri Date: Mon, 13 Apr 2015 20:57:12 +0200 In-Reply-To: <858a607d-7c5a-4066-aa79-ab14c456b8e5@BN1BFFO11FD046.protection.gbl> References: <1428941550-4620-1-git-send-email-punnaia@xilinx.com> <858a607d-7c5a-4066-aa79-ab14c456b8e5@BN1BFFO11FD046.protection.gbl> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Cc: mark.rutland@arm.com, jussi.kivilinna@iki.fi, linux-doc@vger.kernel.org, artem.bityutskiy@linux.intel.com, linux-mtd@lists.infradead.org, Punnaiah Choudary Kalluri , arnd@arndb.de, michal.simek@xilinx.com, ezequiel.garcia@free-electrons.com, grant.likely@linaro.org, devicetree@vger.kernel.org, jason@lakedaemon.net, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, joern@logfs.org, kpc528@gmail.com, robh+dt@kernel.org, acourbot@nvidia.com, kalluripunnaiahchoudary@gmail.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, rob@landley.net, galak@codeaurora.org, ivan.khoronzhuk@ti.com, computersforpeace@gmail.com, dwmw2@infradead.org List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 2015-04-13 at 21:42 +0530, Punnaiah Choudary Kalluri wrote: > --- a/drivers/mtd/nand/Makefile > +++ b/drivers/mtd/nand/Makefile > +obj-$(CONFIG_MTD_NAND_PL353) += pl353_nand.o (I think pl353_nand.o can be part of a module. If that's incorrect, you can stop reading here.) > --- /dev/null > +++ b/drivers/mtd/nand/pl353_nand.c > + * This program is free software; you can redistribute it and/or modify it under > + * the terms of the GNU General Public License version 2 as published by the > + * Free Software Foundation; either version 2 of the License, or (at your > + * option) any later version. This states the license of this driver is GPL v2 or later. > +MODULE_LICENSE("GPL v2"); And according to include/linux/module.h this states the license is GPL v2. So either the comment at the top of this file or the license ident used in the MODULE_LICENSE() macro needs to change. Thanks, Paul Bolle